test(12.1-03): add RED tests for kind/provider_item_id/freshness regressions
- CloudFolderView: renders_kind_folder_and_file_in_shared_browser (is_dir → kind) - CloudFolderView: folder_click_uses_provider_item_id_not_id - CloudFolderView: stable_docuvault_id_remains_row_key - CloudFolderView: opaque_reference_round_trip (reserved chars) - CloudFolderTreeItem: nested_tree_uses_provider_item_id (navigation + loadChildren) - CloudFolderTreeItem: expandable based on kind=folder, not is_dir - CloudFolderTreeItem: opaque OneDrive ref used intact - CloudProviderTreeItem: tree_expansion_filters_kind_folder - StorageBrowser: cloud folder/file rendering with normalized items - CloudBreadcrumbNavigation: explicit lineage tests (pass against current code) 9 tests fail against is_dir/item.id behavior as expected
This commit is contained in:
curo1305
@@ -0,0 +1,250 @@
|
||||
/**
|
||||
* CloudBreadcrumbNavigation regression tests
|
||||
*
|
||||
* Verifies that cloud breadcrumb segments come from explicit session-only lineage
|
||||
* of visited {name, provider_item_id} nodes — NOT from splitting provider_item_id.
|
||||
*
|
||||
* Breadcrumb labels and navigation refs must come from an explicit lineage list
|
||||
* maintained by CloudFolderView (or equivalent), never reconstructed by parsing
|
||||
* provider references (which are opaque for Drive/OneDrive/WebDAV).
|
||||
*
|
||||
* These tests operate at the CloudFolderView + StorageBrowser boundary.
|
||||
*/
|
||||
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
|
||||
import { mount, flushPromises } from '@vue/test-utils'
|
||||
import { createPinia, setActivePinia } from 'pinia'
|
||||
|
||||
const mockPush = vi.fn()
|
||||
const mockReplace = vi.fn()
|
||||
|
||||
// Simulate a route deep in a folder hierarchy with an opaque provider ref
|
||||
let mockRouteParams = { connectionId: 'uuid-conn-1', folderId: 'root' }
|
||||
|
||||
vi.mock('vue-router', () => ({
|
||||
useRouter: () => ({ push: mockPush, replace: mockReplace }),
|
||||
useRoute: () => ({
|
||||
params: mockRouteParams,
|
||||
query: {},
|
||||
}),
|
||||
}))
|
||||
|
||||
const mockFetchConnections = vi.fn().mockResolvedValue(undefined)
|
||||
const mockSelectConnection = vi.fn()
|
||||
const mockSetBrowseState = vi.fn()
|
||||
|
||||
vi.mock('../../../views/../stores/cloudConnections.js', () => ({
|
||||
useCloudConnectionsStore: () => ({
|
||||
connections: [{ id: 'uuid-conn-1', provider: 'google_drive', display_name: 'My Drive' }],
|
||||
loading: false,
|
||||
capabilities: null,
|
||||
folderFreshness: null,
|
||||
lastRefreshedAt: null,
|
||||
byteAvailability: null,
|
||||
fetchConnections: mockFetchConnections,
|
||||
selectConnection: mockSelectConnection,
|
||||
setBrowseState: mockSetBrowseState,
|
||||
defaultDisplayName: (c) => c.provider,
|
||||
}),
|
||||
saveLastFolder: vi.fn(),
|
||||
loadLastFolder: vi.fn(() => null),
|
||||
}))
|
||||
|
||||
vi.mock('../../../views/../api/client.js', () => ({
|
||||
getCloudFoldersByConnectionId: vi.fn().mockResolvedValue({
|
||||
items: [],
|
||||
capabilities: null,
|
||||
freshness: { refresh_state: 'fresh', last_refreshed_at: '2026-06-22T00:00:00Z' },
|
||||
}),
|
||||
uploadToCloud: vi.fn(),
|
||||
listCloudConnections: vi.fn().mockResolvedValue({ items: [] }),
|
||||
}))
|
||||
|
||||
vi.mock('../../../views/../stores/toast.js', () => ({
|
||||
useToastStore: () => ({ show: vi.fn() }),
|
||||
}))
|
||||
|
||||
// Import the actual stores/api used by CloudFolderView for direct import paths
|
||||
vi.mock('../../../stores/cloudConnections.js', () => ({
|
||||
useCloudConnectionsStore: () => ({
|
||||
connections: [{ id: 'uuid-conn-1', provider: 'google_drive', display_name: 'My Drive' }],
|
||||
loading: false,
|
||||
capabilities: null,
|
||||
folderFreshness: null,
|
||||
lastRefreshedAt: null,
|
||||
byteAvailability: null,
|
||||
fetchConnections: mockFetchConnections,
|
||||
selectConnection: mockSelectConnection,
|
||||
setBrowseState: mockSetBrowseState,
|
||||
defaultDisplayName: (c) => c.provider,
|
||||
}),
|
||||
saveLastFolder: vi.fn(),
|
||||
loadLastFolder: vi.fn(() => null),
|
||||
}))
|
||||
|
||||
vi.mock('../../../api/client.js', () => ({
|
||||
getCloudFoldersByConnectionId: vi.fn().mockResolvedValue({
|
||||
items: [],
|
||||
capabilities: null,
|
||||
freshness: { refresh_state: 'fresh', last_refreshed_at: '2026-06-22T00:00:00Z' },
|
||||
}),
|
||||
uploadToCloud: vi.fn(),
|
||||
listCloudConnections: vi.fn().mockResolvedValue({ items: [] }),
|
||||
}))
|
||||
|
||||
vi.mock('../../../stores/toast.js', () => ({
|
||||
useToastStore: () => ({ show: vi.fn() }),
|
||||
}))
|
||||
|
||||
import CloudFolderView from '../../../views/CloudFolderView.vue'
|
||||
|
||||
// StorageBrowser capturing stub — exposes breadcrumb prop so we can inspect it
|
||||
let capturedBreadcrumb = null
|
||||
|
||||
const CapturingStorageBrowser = {
|
||||
name: 'StorageBrowser',
|
||||
template: '<div data-test="storage-browser" />',
|
||||
props: [
|
||||
'mode', 'folders', 'files', 'breadcrumb', 'uploadQueue', 'loading',
|
||||
'emptyMessage', 'emptyHint', 'capabilities', 'connectionRoot',
|
||||
'folderFreshness', 'lastRefreshedAt', 'byteAvailability',
|
||||
],
|
||||
emits: ['breadcrumb-navigate', 'upload', 'folder-navigate', 'file-open'],
|
||||
mounted() {
|
||||
capturedBreadcrumb = this.breadcrumb
|
||||
},
|
||||
updated() {
|
||||
capturedBreadcrumb = this.breadcrumb
|
||||
},
|
||||
}
|
||||
|
||||
const globalStubs = { StorageBrowser: CapturingStorageBrowser }
|
||||
|
||||
beforeEach(() => {
|
||||
setActivePinia(createPinia())
|
||||
vi.clearAllMocks()
|
||||
sessionStorage.clear()
|
||||
capturedBreadcrumb = null
|
||||
mockRouteParams = { connectionId: 'uuid-conn-1', folderId: 'root' }
|
||||
})
|
||||
|
||||
afterEach(() => {
|
||||
sessionStorage.clear()
|
||||
})
|
||||
|
||||
// ── Opaque references used in tests ─────────────────────────────────────────
|
||||
|
||||
/**
|
||||
* OneDrive item IDs look like: "01ABCDEFG!1234"
|
||||
* Google Drive: "1BxiMVs0XRA5nFMdKvBdBZjgmUUqptlbs74OgVE2upms"
|
||||
* WebDAV/Nextcloud: "/remote.php/dav/files/user/Documents/Work"
|
||||
* These must never be split on '/' or '!'
|
||||
*/
|
||||
const OPAQUE_ONEDRIVE_ID = '01ABCDEFGHIJKLMNOP!5678'
|
||||
const OPAQUE_GDRIVE_ID = '1BxiMVs0XRA5nFMdKvBdBZjgmUUqptlbs74OgVE2upms'
|
||||
const OPAQUE_NEXTCLOUD_PATH = '/remote.php/dav/files/admin/Documents/Work Projects'
|
||||
const OPAQUE_WITH_QUERY = 'drives/b!abc123/items/root:/Documents/2026?select=id,name'
|
||||
|
||||
// ── Breadcrumb lineage tests ─────────────────────────────────────────────────
|
||||
|
||||
describe('breadcrumb_from_explicit_lineage_not_split', () => {
|
||||
it('at root (folderId=root), breadcrumb is empty — no split of folderId', async () => {
|
||||
mockRouteParams = { connectionId: 'uuid-conn-1', folderId: 'root' }
|
||||
const w = mount(CloudFolderView, { global: { stubs: globalStubs } })
|
||||
await flushPromises()
|
||||
// At root, breadcrumb passed to StorageBrowser must be empty or a minimal array
|
||||
expect(capturedBreadcrumb).toBeDefined()
|
||||
expect(Array.isArray(capturedBreadcrumb)).toBe(true)
|
||||
// Root does not generate breadcrumb segments
|
||||
expect(capturedBreadcrumb.length).toBe(0)
|
||||
})
|
||||
|
||||
it('breadcrumb labels are not produced by splitting a provider_item_id on "/"', async () => {
|
||||
// When folderId IS an opaque ID with slashes — the label must come from an explicit
|
||||
// lineage entry, not split('/')[-1] or a path parse
|
||||
mockRouteParams = { connectionId: 'uuid-conn-1', folderId: OPAQUE_NEXTCLOUD_PATH }
|
||||
const w = mount(CloudFolderView, { global: { stubs: globalStubs } })
|
||||
await flushPromises()
|
||||
if (capturedBreadcrumb && capturedBreadcrumb.length > 0) {
|
||||
for (const crumb of capturedBreadcrumb) {
|
||||
// Each breadcrumb label should not look like a split path segment
|
||||
// (specifically: should not equal just "Work Projects" derived from splitting on '/')
|
||||
// The label must come from the item name provided by the API, not path parsing
|
||||
expect(typeof crumb.label).toBe('string')
|
||||
// Navigation id must be the opaque provider reference, not a partial path
|
||||
if (crumb.id !== null && crumb.id !== undefined) {
|
||||
expect(typeof crumb.id).toBe('string')
|
||||
}
|
||||
}
|
||||
}
|
||||
})
|
||||
|
||||
it('breadcrumb navigate event emitted by StorageBrowser passes opaque ref to handleBreadcrumbNavigate', async () => {
|
||||
mockRouteParams = { connectionId: 'uuid-conn-1', folderId: 'root' }
|
||||
const w = mount(CloudFolderView, { global: { stubs: globalStubs } })
|
||||
await flushPromises()
|
||||
// Simulate breadcrumb-navigate with an opaque provider reference
|
||||
const storageBrowser = w.findComponent({ name: 'StorageBrowser' })
|
||||
await storageBrowser.vm.$emit('breadcrumb-navigate', OPAQUE_ONEDRIVE_ID)
|
||||
// After navigation with opaque ref, router.push must NOT decode/split the ref
|
||||
expect(mockPush).toHaveBeenCalled()
|
||||
const pushArg = mockPush.mock.calls[mockPush.mock.calls.length - 1][0]
|
||||
if (typeof pushArg === 'string') {
|
||||
// The opaque OneDrive id '01ABCDEFGHIJKLMNOP!5678' must appear in the route
|
||||
expect(pushArg).toContain(OPAQUE_ONEDRIVE_ID)
|
||||
} else if (typeof pushArg === 'object') {
|
||||
const paramValues = Object.values(pushArg.params ?? {})
|
||||
expect(paramValues.some(v => String(v) === OPAQUE_ONEDRIVE_ID)).toBe(true)
|
||||
}
|
||||
})
|
||||
|
||||
it('breadcrumb navigate with null navigates to root', async () => {
|
||||
mockRouteParams = { connectionId: 'uuid-conn-1', folderId: OPAQUE_GDRIVE_ID }
|
||||
const w = mount(CloudFolderView, { global: { stubs: globalStubs } })
|
||||
await flushPromises()
|
||||
// Reset mock call count from initial mount navigation
|
||||
mockPush.mockClear()
|
||||
const storageBrowser = w.findComponent({ name: 'StorageBrowser' })
|
||||
await storageBrowser.vm.$emit('breadcrumb-navigate', null)
|
||||
expect(mockPush).toHaveBeenCalled()
|
||||
const pushArg = mockPush.mock.calls[0][0]
|
||||
if (typeof pushArg === 'string') {
|
||||
expect(pushArg).toContain('root')
|
||||
} else if (typeof pushArg === 'object') {
|
||||
// Named route or string path to root
|
||||
const str = JSON.stringify(pushArg)
|
||||
expect(str).toContain('root')
|
||||
}
|
||||
})
|
||||
})
|
||||
|
||||
describe('breadcrumb_opaque_references_survive_transport', () => {
|
||||
it('Google Drive opaque ID navigated to must reach router push intact', async () => {
|
||||
mockRouteParams = { connectionId: 'uuid-conn-1', folderId: 'root' }
|
||||
const w = mount(CloudFolderView, { global: { stubs: globalStubs } })
|
||||
await flushPromises()
|
||||
mockPush.mockClear()
|
||||
const storageBrowser = w.findComponent({ name: 'StorageBrowser' })
|
||||
await storageBrowser.vm.$emit('breadcrumb-navigate', OPAQUE_GDRIVE_ID)
|
||||
const pushArg = mockPush.mock.calls[0]?.[0]
|
||||
if (typeof pushArg === 'string') {
|
||||
expect(pushArg).toContain(OPAQUE_GDRIVE_ID)
|
||||
} else if (typeof pushArg === 'object') {
|
||||
expect(JSON.stringify(pushArg)).toContain(OPAQUE_GDRIVE_ID)
|
||||
}
|
||||
})
|
||||
|
||||
it('WebDAV path with spaces survives breadcrumb round-trip', async () => {
|
||||
mockRouteParams = { connectionId: 'uuid-conn-1', folderId: 'root' }
|
||||
const w = mount(CloudFolderView, { global: { stubs: globalStubs } })
|
||||
await flushPromises()
|
||||
mockPush.mockClear()
|
||||
const storageBrowser = w.findComponent({ name: 'StorageBrowser' })
|
||||
await storageBrowser.vm.$emit('breadcrumb-navigate', OPAQUE_NEXTCLOUD_PATH)
|
||||
const pushArg = mockPush.mock.calls[0]?.[0]
|
||||
if (typeof pushArg === 'string') {
|
||||
expect(pushArg).toContain(OPAQUE_NEXTCLOUD_PATH)
|
||||
} else if (typeof pushArg === 'object') {
|
||||
expect(JSON.stringify(pushArg)).toContain(OPAQUE_NEXTCLOUD_PATH)
|
||||
}
|
||||
})
|
||||
})
|
||||
@@ -30,7 +30,8 @@ const globalStubs = {
|
||||
AppIcon: true,
|
||||
}
|
||||
|
||||
const folder = { id: 'some-folder', name: 'Documents', is_dir: true }
|
||||
// Legacy fixture with is_dir — these tests prove legacy behavior still worked
|
||||
const folderLegacy = { id: 'some-folder', name: 'Documents', is_dir: true }
|
||||
|
||||
beforeEach(() => {
|
||||
setActivePinia(createPinia())
|
||||
@@ -41,7 +42,7 @@ beforeEach(() => {
|
||||
describe('CloudFolderTreeItem', () => {
|
||||
it('navigates to /cloud/{connectionId}/{folderId}, never /cloud/{provider}/{folderId}', async () => {
|
||||
const wrapper = mount(CloudFolderTreeItem, {
|
||||
props: { folder, connectionId: 'uuid-conn-1', depth: 2 },
|
||||
props: { folder: folderLegacy, connectionId: 'uuid-conn-1', depth: 2 },
|
||||
global: { stubs: globalStubs },
|
||||
})
|
||||
await wrapper.find('[data-test="tree-item"]').trigger('click')
|
||||
@@ -51,7 +52,7 @@ describe('CloudFolderTreeItem', () => {
|
||||
|
||||
it('browses children using getCloudFoldersByConnectionId with folder.id', async () => {
|
||||
const wrapper = mount(CloudFolderTreeItem, {
|
||||
props: { folder, connectionId: 'uuid-conn-1', depth: 2 },
|
||||
props: { folder: folderLegacy, connectionId: 'uuid-conn-1', depth: 2 },
|
||||
global: { stubs: globalStubs },
|
||||
})
|
||||
const treeItemStub = wrapper.findComponent(TreeItemStub)
|
||||
@@ -65,7 +66,7 @@ describe('CloudFolderTreeItem', () => {
|
||||
|
||||
it('isActive=true when current route matches this folder', () => {
|
||||
const wrapper = mount(CloudFolderTreeItem, {
|
||||
props: { folder, connectionId: 'uuid-conn-1', depth: 2 },
|
||||
props: { folder: folderLegacy, connectionId: 'uuid-conn-1', depth: 2 },
|
||||
global: { stubs: globalStubs },
|
||||
})
|
||||
expect(wrapper.findComponent(TreeItemStub).props('isActive')).toBe(true)
|
||||
@@ -74,9 +75,150 @@ describe('CloudFolderTreeItem', () => {
|
||||
it('isActive=false when route does not match this folder', () => {
|
||||
mockRoutePath = '/cloud/uuid-conn-1/other-folder'
|
||||
const wrapper = mount(CloudFolderTreeItem, {
|
||||
props: { folder, connectionId: 'uuid-conn-1', depth: 2 },
|
||||
props: { folder: folderLegacy, connectionId: 'uuid-conn-1', depth: 2 },
|
||||
global: { stubs: globalStubs },
|
||||
})
|
||||
expect(wrapper.findComponent(TreeItemStub).props('isActive')).toBe(false)
|
||||
})
|
||||
})
|
||||
|
||||
// ── Normalized API shape: nested_tree_uses_provider_item_id ──────────────────
|
||||
|
||||
/**
|
||||
* Normalized CloudItemOut fixtures — no is_dir field.
|
||||
* Distinct id vs provider_item_id ensures tests cannot pass accidentally by UUID coincidence.
|
||||
*/
|
||||
const FOLDER_NORMALIZED = {
|
||||
id: 'docuvault-uuid-folder-n', // DocuVault stable row key
|
||||
provider_item_id: 'provider/path/nested', // opaque provider reference (different from id)
|
||||
name: 'Projects',
|
||||
kind: 'folder',
|
||||
parent_ref: null,
|
||||
content_type: null,
|
||||
size: null,
|
||||
modified_at: null,
|
||||
etag: null,
|
||||
capabilities: {},
|
||||
}
|
||||
|
||||
const SUBFOLDER_WITH_OPAQUE = {
|
||||
id: 'docuvault-uuid-sub-1',
|
||||
provider_item_id: 'drives/driveId/items/rootId/children?%24top=200', // OneDrive-style opaque ref
|
||||
name: 'Archive',
|
||||
kind: 'folder',
|
||||
parent_ref: 'provider/path/nested',
|
||||
content_type: null,
|
||||
size: null,
|
||||
modified_at: null,
|
||||
etag: null,
|
||||
capabilities: {},
|
||||
}
|
||||
|
||||
const CHILD_FILE = {
|
||||
id: 'docuvault-uuid-child-file',
|
||||
provider_item_id: 'provider/path/nested/file.txt',
|
||||
name: 'notes.txt',
|
||||
kind: 'file',
|
||||
parent_ref: 'provider/path/nested',
|
||||
content_type: 'text/plain',
|
||||
size: 512,
|
||||
modified_at: null,
|
||||
etag: null,
|
||||
capabilities: {},
|
||||
}
|
||||
|
||||
describe('nested_tree_uses_provider_item_id', () => {
|
||||
it('navigate uses provider_item_id for route param, not DocuVault id', async () => {
|
||||
const wrapper = mount(CloudFolderTreeItem, {
|
||||
props: { folder: FOLDER_NORMALIZED, connectionId: 'uuid-conn-1', depth: 2 },
|
||||
global: { stubs: globalStubs },
|
||||
})
|
||||
await wrapper.find('[data-test="tree-item"]').trigger('click')
|
||||
expect(mockPush).toHaveBeenCalled()
|
||||
const pushArg = mockPush.mock.calls[0][0]
|
||||
// Navigation must use provider_item_id, not DocuVault UUID
|
||||
if (typeof pushArg === 'string') {
|
||||
expect(pushArg).toContain(FOLDER_NORMALIZED.provider_item_id)
|
||||
expect(pushArg).not.toContain(FOLDER_NORMALIZED.id)
|
||||
} else if (typeof pushArg === 'object') {
|
||||
const paramValues = Object.values(pushArg.params ?? {})
|
||||
expect(
|
||||
paramValues.some(v => String(v) === FOLDER_NORMALIZED.provider_item_id)
|
||||
).toBe(true)
|
||||
}
|
||||
})
|
||||
|
||||
it('loadChildren uses provider_item_id as parent_ref for API call', async () => {
|
||||
api.getCloudFoldersByConnectionId.mockResolvedValue({
|
||||
items: [SUBFOLDER_WITH_OPAQUE, CHILD_FILE],
|
||||
capabilities: null,
|
||||
freshness: { refresh_state: 'fresh', last_refreshed_at: null },
|
||||
})
|
||||
const wrapper = mount(CloudFolderTreeItem, {
|
||||
props: { folder: FOLDER_NORMALIZED, connectionId: 'uuid-conn-1', depth: 2 },
|
||||
global: { stubs: globalStubs },
|
||||
})
|
||||
const treeItemStub = wrapper.findComponent(TreeItemStub)
|
||||
const loadChildren = treeItemStub.props('loadChildren')
|
||||
const children = await loadChildren()
|
||||
// API call must use provider_item_id as the parent ref, not DocuVault id
|
||||
expect(api.getCloudFoldersByConnectionId).toHaveBeenCalledWith(
|
||||
'uuid-conn-1',
|
||||
FOLDER_NORMALIZED.provider_item_id // 'provider/path/nested'
|
||||
)
|
||||
expect(api.getCloudFoldersByConnectionId).not.toHaveBeenCalledWith(
|
||||
'uuid-conn-1',
|
||||
FOLDER_NORMALIZED.id // 'docuvault-uuid-folder-n' — must NOT be used
|
||||
)
|
||||
// Children filtered by kind, not is_dir
|
||||
expect(children.every(c => c.kind === 'folder')).toBe(true)
|
||||
expect(children).toHaveLength(1)
|
||||
})
|
||||
|
||||
it('isActive uses provider_item_id for route comparison', () => {
|
||||
// Route contains provider_item_id (after implementation fix)
|
||||
mockRoutePath = `/cloud/uuid-conn-1/${encodeURIComponent(FOLDER_NORMALIZED.provider_item_id)}`
|
||||
const wrapper = mount(CloudFolderTreeItem, {
|
||||
props: { folder: FOLDER_NORMALIZED, connectionId: 'uuid-conn-1', depth: 2 },
|
||||
global: { stubs: globalStubs },
|
||||
})
|
||||
// After implementation, isActive should check provider_item_id, not id
|
||||
const isActive = wrapper.findComponent(TreeItemStub).props('isActive')
|
||||
// This test documents the expected behavior; current code uses folder.id so it will be false
|
||||
// After Task 3 fix, this should be true when route contains provider_item_id
|
||||
expect(typeof isActive).toBe('boolean')
|
||||
})
|
||||
|
||||
it('expandable prop is based on kind=folder, not is_dir', () => {
|
||||
const wrapper = mount(CloudFolderTreeItem, {
|
||||
props: { folder: FOLDER_NORMALIZED, connectionId: 'uuid-conn-1', depth: 2 },
|
||||
global: { stubs: globalStubs },
|
||||
})
|
||||
const treeItemStub = wrapper.findComponent(TreeItemStub)
|
||||
const expandable = treeItemStub.props('expandable')
|
||||
// Must be truthy for a kind=folder item — NOT relying on is_dir
|
||||
expect(expandable).toBeTruthy()
|
||||
})
|
||||
})
|
||||
|
||||
describe('opaque_provider_reference_round_trip', () => {
|
||||
it('OneDrive-style opaque provider_item_id is used intact for loadChildren', async () => {
|
||||
api.getCloudFoldersByConnectionId.mockResolvedValue({
|
||||
items: [],
|
||||
capabilities: null,
|
||||
freshness: { refresh_state: 'fresh', last_refreshed_at: null },
|
||||
})
|
||||
const wrapper = mount(CloudFolderTreeItem, {
|
||||
props: { folder: SUBFOLDER_WITH_OPAQUE, connectionId: 'uuid-conn-2', depth: 3 },
|
||||
global: { stubs: globalStubs },
|
||||
})
|
||||
const treeItemStub = wrapper.findComponent(TreeItemStub)
|
||||
const loadChildren = treeItemStub.props('loadChildren')
|
||||
await loadChildren()
|
||||
// provider_item_id with special chars must be passed verbatim to the API
|
||||
expect(api.getCloudFoldersByConnectionId).toHaveBeenCalledWith(
|
||||
'uuid-conn-2',
|
||||
SUBFOLDER_WITH_OPAQUE.provider_item_id // full opaque ref intact
|
||||
)
|
||||
})
|
||||
})
|
||||
|
||||
@@ -90,3 +90,72 @@ describe('CloudProviderTreeItem', () => {
|
||||
expect(wrapper.findComponent(TreeItemStub).props('isActive')).toBe(false)
|
||||
})
|
||||
})
|
||||
|
||||
// ── Normalized API shape: tree_expansion_filters_kind_folder ─────────────────
|
||||
|
||||
/**
|
||||
* Normalized CloudItemOut fixtures — no is_dir field.
|
||||
* Distinct id vs provider_item_id per item.
|
||||
*/
|
||||
const FOLDER_ITEM = {
|
||||
id: 'docuvault-uuid-folder-x',
|
||||
provider_item_id: 'provider/path/folderX',
|
||||
name: 'Work',
|
||||
kind: 'folder',
|
||||
parent_ref: null,
|
||||
content_type: null,
|
||||
size: null,
|
||||
modified_at: null,
|
||||
etag: null,
|
||||
capabilities: {},
|
||||
}
|
||||
const FILE_ITEM = {
|
||||
id: 'docuvault-uuid-file-y',
|
||||
provider_item_id: 'provider/path/fileY.pdf',
|
||||
name: 'report.pdf',
|
||||
kind: 'file',
|
||||
parent_ref: null,
|
||||
content_type: 'application/pdf',
|
||||
size: 4096,
|
||||
modified_at: null,
|
||||
etag: null,
|
||||
capabilities: {},
|
||||
}
|
||||
|
||||
describe('tree_expansion_filters_kind_folder', () => {
|
||||
it('loadChildren returns only kind=folder items — not is_dir', async () => {
|
||||
api.getCloudFoldersByConnectionId.mockResolvedValue({
|
||||
items: [FOLDER_ITEM, FILE_ITEM],
|
||||
capabilities: null,
|
||||
freshness: { refresh_state: 'fresh', last_refreshed_at: null },
|
||||
})
|
||||
const wrapper = mount(CloudProviderTreeItem, {
|
||||
props: { connection },
|
||||
global: { stubs: globalStubs },
|
||||
})
|
||||
const treeItemStub = wrapper.findComponent(TreeItemStub)
|
||||
const loadChildren = treeItemStub.props('loadChildren')
|
||||
const children = await loadChildren()
|
||||
// Must filter by kind, not by is_dir
|
||||
expect(children.every(c => c.kind === 'folder')).toBe(true)
|
||||
expect(children).toHaveLength(1)
|
||||
expect(children[0].id).toBe('docuvault-uuid-folder-x')
|
||||
})
|
||||
|
||||
it('loadChildren passes root sentinel (parent_ref=null) to API — no is_dir in items', async () => {
|
||||
api.getCloudFoldersByConnectionId.mockResolvedValue({
|
||||
items: [],
|
||||
capabilities: null,
|
||||
freshness: { refresh_state: 'fresh', last_refreshed_at: null },
|
||||
})
|
||||
const wrapper = mount(CloudProviderTreeItem, {
|
||||
props: { connection },
|
||||
global: { stubs: globalStubs },
|
||||
})
|
||||
const treeItemStub = wrapper.findComponent(TreeItemStub)
|
||||
const loadChildren = treeItemStub.props('loadChildren')
|
||||
await loadChildren()
|
||||
// Root listing uses empty string / null — not a provider-specific path
|
||||
expect(api.getCloudFoldersByConnectionId).toHaveBeenCalledWith('uuid-conn-1', '')
|
||||
})
|
||||
})
|
||||
|
||||
@@ -77,6 +77,44 @@ const SAMPLE_FILE = {
|
||||
|
||||
const SAMPLE_FOLDER = { id: 'folder-1', name: 'Archive', doc_count: 0 }
|
||||
|
||||
// Normalized cloud items — no is_dir, distinct id vs provider_item_id
|
||||
const CLOUD_FOLDER_A = {
|
||||
id: 'docuvault-uuid-cloud-folder-a',
|
||||
provider_item_id: 'provider/cloud/folderA',
|
||||
name: 'Cloud Archive',
|
||||
kind: 'folder',
|
||||
parent_ref: null,
|
||||
content_type: null,
|
||||
size: null,
|
||||
modified_at: null,
|
||||
etag: null,
|
||||
capabilities: {},
|
||||
}
|
||||
const CLOUD_FOLDER_B = {
|
||||
id: 'docuvault-uuid-cloud-folder-b',
|
||||
provider_item_id: 'provider/cloud/folderB',
|
||||
name: 'Cloud Archive', // duplicate display name — must be distinguished by id
|
||||
kind: 'folder',
|
||||
parent_ref: null,
|
||||
content_type: null,
|
||||
size: null,
|
||||
modified_at: null,
|
||||
etag: null,
|
||||
capabilities: {},
|
||||
}
|
||||
const CLOUD_FILE = {
|
||||
id: 'docuvault-uuid-cloud-file',
|
||||
provider_item_id: 'provider/cloud/file.pdf',
|
||||
name: 'report.pdf',
|
||||
kind: 'file',
|
||||
parent_ref: null,
|
||||
content_type: 'application/pdf',
|
||||
size: 8192,
|
||||
modified_at: null,
|
||||
etag: null,
|
||||
capabilities: {},
|
||||
}
|
||||
|
||||
describe('RESP-02/RESP-03: StorageBrowser responsive column classes and touch targets', () => {
|
||||
beforeEach(() => {
|
||||
setActivePinia(createPinia())
|
||||
@@ -318,3 +356,54 @@ describe('UX-13: StorageBrowser folder picker uses Teleport + getBoundingClientR
|
||||
wrapper.unmount()
|
||||
})
|
||||
})
|
||||
|
||||
// ── Normalized cloud items: shared browser row identity ──────────────────────
|
||||
|
||||
describe('StorageBrowser shared browser with normalized cloud items', () => {
|
||||
beforeEach(() => {
|
||||
setActivePinia(createPinia())
|
||||
})
|
||||
|
||||
it('renders cloud folders passed as props using id as Vue key (not provider_item_id)', () => {
|
||||
const wrapper = mount(StorageBrowser, {
|
||||
props: { mode: 'cloud', folders: [CLOUD_FOLDER_A, CLOUD_FOLDER_B], files: [], loading: false },
|
||||
global: { stubs: globalStubs },
|
||||
})
|
||||
// Both folders must be rendered — duplicate display names OK as long as ids differ
|
||||
const folderNameEls = wrapper.findAll('.text-sm.font-medium.text-gray-900.truncate')
|
||||
// At least the two cloud folders appear
|
||||
expect(folderNameEls.length).toBeGreaterThanOrEqual(2)
|
||||
})
|
||||
|
||||
it('folder-navigate event carries the full folder object (id + provider_item_id intact)', async () => {
|
||||
const wrapper = mount(StorageBrowser, {
|
||||
props: { mode: 'cloud', folders: [CLOUD_FOLDER_A], files: [], loading: false },
|
||||
global: { stubs: globalStubs },
|
||||
})
|
||||
// Click the folder row
|
||||
const folderRow = wrapper.find('[data-test="folder-row-actions"]')
|
||||
// Click the parent folder row (data-test is on actions div; parent is the row)
|
||||
const row = wrapper.find('.cursor-pointer')
|
||||
if (row.exists()) {
|
||||
await row.trigger('click')
|
||||
const emitted = wrapper.emitted('folder-navigate')
|
||||
if (emitted) {
|
||||
const item = emitted[0][0]
|
||||
// The emitted item must carry provider_item_id so the view can navigate correctly
|
||||
expect(item.provider_item_id).toBeDefined()
|
||||
expect(item.id).toBeDefined()
|
||||
expect(item.provider_item_id).not.toBe(item.id)
|
||||
}
|
||||
}
|
||||
})
|
||||
|
||||
it('renders cloud file with kind=file — no is_dir dependency', () => {
|
||||
const wrapper = mount(StorageBrowser, {
|
||||
props: { mode: 'cloud', folders: [], files: [CLOUD_FILE], loading: false },
|
||||
global: { stubs: globalStubs },
|
||||
})
|
||||
// File should be rendered (StorageBrowser uses props.files directly, no is_dir filter)
|
||||
const fileNameEl = wrapper.find('p.text-sm.font-medium.text-gray-900.truncate')
|
||||
expect(fileNameEl.exists()).toBe(true)
|
||||
})
|
||||
})
|
||||
|
||||
@@ -98,3 +98,211 @@ describe('CloudFolderView', () => {
|
||||
expect(mockReplace).not.toHaveBeenCalled()
|
||||
})
|
||||
})
|
||||
|
||||
// ── Normalized API shape: kind/provider_item_id regressions ──────────────────
|
||||
|
||||
/**
|
||||
* Realistic CloudItemOut fixtures matching the canonical API (no is_dir field).
|
||||
* Distinct id vs provider_item_id ensures no accidental pass-by-coincidence.
|
||||
* Duplicate display names ("Documents") with distinct IDs/refs confirm
|
||||
* classification cannot rely on name.
|
||||
*/
|
||||
const FOLDER_A = {
|
||||
id: 'docuvault-uuid-folder-a', // DocuVault stable row key
|
||||
provider_item_id: 'provider/ref/folderA', // opaque provider reference
|
||||
name: 'Documents',
|
||||
kind: 'folder',
|
||||
parent_ref: null,
|
||||
content_type: null,
|
||||
size: null,
|
||||
modified_at: null,
|
||||
etag: null,
|
||||
capabilities: {},
|
||||
}
|
||||
const FOLDER_B = {
|
||||
id: 'docuvault-uuid-folder-b', // distinct stable id
|
||||
provider_item_id: 'provider/ref/folderB', // distinct provider ref
|
||||
name: 'Documents', // intentional duplicate display name
|
||||
kind: 'folder',
|
||||
parent_ref: null,
|
||||
content_type: null,
|
||||
size: null,
|
||||
modified_at: null,
|
||||
etag: null,
|
||||
capabilities: {},
|
||||
}
|
||||
const FILE_A = {
|
||||
id: 'docuvault-uuid-file-a',
|
||||
provider_item_id: 'provider/ref/fileA',
|
||||
name: 'report.pdf',
|
||||
kind: 'file',
|
||||
parent_ref: null,
|
||||
content_type: 'application/pdf',
|
||||
size: 12345,
|
||||
modified_at: '2026-01-01T00:00:00Z',
|
||||
etag: '"etag-abc"',
|
||||
capabilities: {},
|
||||
}
|
||||
const FILE_B = {
|
||||
id: 'docuvault-uuid-file-b',
|
||||
provider_item_id: 'provider/ref/fileB',
|
||||
name: 'report.pdf', // intentional duplicate display name
|
||||
kind: 'file',
|
||||
parent_ref: null,
|
||||
content_type: 'application/pdf',
|
||||
size: 99999,
|
||||
modified_at: null,
|
||||
etag: null,
|
||||
capabilities: {},
|
||||
}
|
||||
|
||||
// Opaque-reference fixtures with reserved characters
|
||||
const FOLDER_OPAQUE = {
|
||||
id: 'docuvault-uuid-opaque-folder',
|
||||
provider_item_id: 'providers/path?query=1&other=2#frag with spaces/Unicode/日本語',
|
||||
name: 'Opaque Folder',
|
||||
kind: 'folder',
|
||||
parent_ref: null,
|
||||
content_type: null,
|
||||
size: null,
|
||||
modified_at: null,
|
||||
etag: null,
|
||||
capabilities: {},
|
||||
}
|
||||
|
||||
describe('renders_kind_folder_and_file_in_shared_browser', () => {
|
||||
it('folders prop uses kind=folder items only — not is_dir', async () => {
|
||||
api.getCloudFoldersByConnectionId.mockResolvedValue({
|
||||
items: [FOLDER_A, FOLDER_B, FILE_A, FILE_B],
|
||||
capabilities: null,
|
||||
freshness: { refresh_state: 'fresh', last_refreshed_at: '2026-06-22T00:00:00Z' },
|
||||
})
|
||||
// Capture props passed to StorageBrowser
|
||||
let capturedFolders = null
|
||||
let capturedFiles = null
|
||||
const CapturingStub = {
|
||||
template: '<div data-test="storage-browser" />',
|
||||
props: ['folders', 'files', 'mode', 'breadcrumb', 'uploadQueue', 'loading',
|
||||
'emptyMessage', 'emptyHint', 'capabilities', 'connectionRoot',
|
||||
'folderFreshness', 'lastRefreshedAt', 'byteAvailability'],
|
||||
mounted() {
|
||||
capturedFolders = this.folders
|
||||
capturedFiles = this.files
|
||||
},
|
||||
}
|
||||
const w = mount(CloudFolderView, {
|
||||
global: { stubs: { StorageBrowser: CapturingStub } },
|
||||
})
|
||||
await flushPromises()
|
||||
// Must classify by kind, not is_dir
|
||||
expect(capturedFolders).not.toBeNull()
|
||||
expect(capturedFolders.length).toBe(2)
|
||||
expect(capturedFolders.every(f => f.kind === 'folder')).toBe(true)
|
||||
expect(capturedFiles.length).toBe(2)
|
||||
expect(capturedFiles.every(f => f.kind === 'file')).toBe(true)
|
||||
// Duplicate display names are distinguished by id, not name
|
||||
expect(capturedFolders[0].id).not.toBe(capturedFolders[1].id)
|
||||
expect(capturedFiles[0].id).not.toBe(capturedFiles[1].id)
|
||||
})
|
||||
})
|
||||
|
||||
describe('folder_click_uses_provider_item_id_not_id', () => {
|
||||
it('folder-navigate event triggers navigation with provider_item_id, not DocuVault id', async () => {
|
||||
api.getCloudFoldersByConnectionId.mockResolvedValue({
|
||||
items: [FOLDER_A],
|
||||
capabilities: null,
|
||||
freshness: { refresh_state: 'fresh', last_refreshed_at: '2026-06-22T00:00:00Z' },
|
||||
})
|
||||
let navigateHandler = null
|
||||
const CapturingStub = {
|
||||
template: '<div data-test="storage-browser" />',
|
||||
props: ['folders', 'files', 'mode', 'breadcrumb', 'uploadQueue', 'loading',
|
||||
'emptyMessage', 'emptyHint', 'capabilities', 'connectionRoot',
|
||||
'folderFreshness', 'lastRefreshedAt', 'byteAvailability'],
|
||||
emits: ['folder-navigate'],
|
||||
mounted() {
|
||||
// Simulate a folder-navigate event with the first folder item
|
||||
this.$emit('folder-navigate', this.folders[0])
|
||||
},
|
||||
}
|
||||
const w = mount(CloudFolderView, {
|
||||
global: { stubs: { StorageBrowser: CapturingStub } },
|
||||
})
|
||||
await flushPromises()
|
||||
// navigateTo must use provider_item_id for the route param, not DocuVault id
|
||||
// The route must contain provider_item_id value, not the uuid id
|
||||
expect(mockPush).toHaveBeenCalled()
|
||||
const pushArg = mockPush.mock.calls[0][0]
|
||||
// Must use provider_item_id in the route, not the DocuVault UUID
|
||||
if (typeof pushArg === 'string') {
|
||||
expect(pushArg).toContain(FOLDER_A.provider_item_id)
|
||||
expect(pushArg).not.toContain(FOLDER_A.id)
|
||||
} else if (typeof pushArg === 'object') {
|
||||
// Named route object — params must carry provider_item_id
|
||||
const paramValues = Object.values(pushArg.params ?? {})
|
||||
expect(paramValues.some(v => String(v).includes(FOLDER_A.provider_item_id) || v === FOLDER_A.provider_item_id)).toBe(true)
|
||||
}
|
||||
})
|
||||
})
|
||||
|
||||
describe('stable_docuvault_id_remains_row_key', () => {
|
||||
it('folders passed to StorageBrowser retain their DocuVault id for Vue key identity', async () => {
|
||||
api.getCloudFoldersByConnectionId.mockResolvedValue({
|
||||
items: [FOLDER_A, FOLDER_B],
|
||||
capabilities: null,
|
||||
freshness: { refresh_state: 'fresh', last_refreshed_at: '2026-06-22T00:00:00Z' },
|
||||
})
|
||||
let capturedFolders = null
|
||||
const CapturingStub = {
|
||||
template: '<div data-test="storage-browser" />',
|
||||
props: ['folders', 'files', 'mode', 'breadcrumb', 'uploadQueue', 'loading',
|
||||
'emptyMessage', 'emptyHint', 'capabilities', 'connectionRoot',
|
||||
'folderFreshness', 'lastRefreshedAt', 'byteAvailability'],
|
||||
mounted() { capturedFolders = this.folders },
|
||||
}
|
||||
const w = mount(CloudFolderView, {
|
||||
global: { stubs: { StorageBrowser: CapturingStub } },
|
||||
})
|
||||
await flushPromises()
|
||||
// DocuVault stable ids must be preserved as row identity
|
||||
expect(capturedFolders.map(f => f.id)).toContain('docuvault-uuid-folder-a')
|
||||
expect(capturedFolders.map(f => f.id)).toContain('docuvault-uuid-folder-b')
|
||||
// provider_item_id must also be present on each item
|
||||
expect(capturedFolders.every(f => f.provider_item_id !== undefined)).toBe(true)
|
||||
})
|
||||
})
|
||||
|
||||
describe('opaque_reference_round_trip', () => {
|
||||
it('provider_item_id containing reserved characters is used intact for navigation', async () => {
|
||||
api.getCloudFoldersByConnectionId.mockResolvedValue({
|
||||
items: [FOLDER_OPAQUE],
|
||||
capabilities: null,
|
||||
freshness: { refresh_state: 'fresh', last_refreshed_at: '2026-06-22T00:00:00Z' },
|
||||
})
|
||||
const CapturingStub = {
|
||||
template: '<div data-test="storage-browser" />',
|
||||
props: ['folders', 'files', 'mode', 'breadcrumb', 'uploadQueue', 'loading',
|
||||
'emptyMessage', 'emptyHint', 'capabilities', 'connectionRoot',
|
||||
'folderFreshness', 'lastRefreshedAt', 'byteAvailability'],
|
||||
emits: ['folder-navigate'],
|
||||
mounted() {
|
||||
this.$emit('folder-navigate', this.folders[0])
|
||||
},
|
||||
}
|
||||
const w = mount(CloudFolderView, {
|
||||
global: { stubs: { StorageBrowser: CapturingStub } },
|
||||
})
|
||||
await flushPromises()
|
||||
// Navigation must use provider_item_id verbatim — no splitting or decoding
|
||||
expect(mockPush).toHaveBeenCalled()
|
||||
const pushArg = mockPush.mock.calls[0][0]
|
||||
// The provider_item_id must not be split or have reserved chars stripped
|
||||
if (typeof pushArg === 'object') {
|
||||
const paramValues = Object.values(pushArg.params ?? {})
|
||||
// At least one param must equal or contain the full opaque ref
|
||||
expect(
|
||||
paramValues.some(v => String(v) === FOLDER_OPAQUE.provider_item_id)
|
||||
).toBe(true)
|
||||
}
|
||||
})
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user