Commit Graph
757 Commits
Author SHA1 Message Date
curo1305 d7bda3c605 feat(10-09): add global keydown handler to App.vue — /, Escape, U, N shortcuts live
- Add routeViewRef = ref(null) and bind to <router-view ref="routeViewRef">
- Add onKeydown handler: guards INPUT/TEXTAREA/SELECT/contenteditable; routes / → focusSearch, Escape → clearSearch, U/u → triggerUpload, N/n → startNewFolder
- Chain document.addEventListener on onMounted, removeEventListener on onUnmounted
- Add double optional chaining (?.) in StorageBrowser.triggerUpload and focusSearch so stubs don't throw in tests
- 9 keyboard shortcut tests GREEN; full suite 190 passing 0 failures
2026-06-15 20:36:52 +02:00
curo1305 aaa0532af9 feat(10-09): plumb keyboard shortcut ref chain — DropZone→SearchBar→StorageBrowser→FileManagerView
- DropZone: defineExpose({ triggerInput }) to expose file picker trigger
- SearchBar: add inputEl ref + defineExpose({ focus }) for / shortcut
- StorageBrowser: add dropZoneRef + searchBarRef; expand defineExpose to include triggerUpload, focusSearch, clearSearch
- FileManagerView: add defineExpose delegating all four methods to browserRef via optional chaining
2026-06-15 20:35:38 +02:00
curo1305 089af90e6d test(10-09): promote keyboard stubs to 9 RED failing tests for UX-05/06/07/08
- Replace 11 it.todo stubs with 9 real it() assertions
- Tests verify FileManagerView exposes focusSearch, clearSearch, triggerUpload, startNewFolder
- All 9 tests are RED — defineExpose not yet added to FileManagerView
2026-06-15 20:34:15 +02:00
curo1305 9a435f8fc0 docs(phase-10): update tracking after wave 1 complete (8/12 plans) 2026-06-15 20:30:58 +02:00
curo1305 776a1d9948 chore: merge executor worktree (10-08 admin views wiring) 2026-06-15 20:30:25 +02:00
curo1305 365b0b4eca chore: merge executor worktree (10-07 AppSidebar wiring) 2026-06-15 20:30:25 +02:00
curo1305 6fe8279c90 chore: merge executor worktree (10-06 StorageBrowser+FileManager wiring) 2026-06-15 20:30:25 +02:00
curo1305 d2110c9a98 docs(10-07): complete AppSidebar skeleton + EmptyState micro + UX-14 plan
- UX-03 skeletons, UX-01 sidebar micro EmptyState, UX-14 New button removed
- 9/9 tests GREEN; StorageBrowser.startNewFolder invariant preserved
2026-06-15 20:29:21 +02:00
curo1305 24a5cbc112 docs(10-08): complete plan — admin skeletons, EmptyStates, and BreadcrumbBar wiring
- All 3 tasks complete; 8 TDD skeleton tests GREEN
- 8 views updated with BreadcrumbBar (showRoot=false)
- AdminAuditView + AdminUsersView: animated skeleton tbody rows
- AdminAuditView + SharedView + CloudStorageView: EmptyState components
- Full worktree test suite: 178/178 pass
2026-06-15 20:28:27 +02:00
curo1305 1728de77f3 feat(10-07): AppSidebar UX-03 skeletons, UX-01 EmptyState micro, UX-14 remove New button
- UX-14: remove startNewFolder/cancelNewFolder/submitNewFolder + all related state
  (showNewFolderInput, newFolderName, newFolderError) from script and template
- UX-14: remove <button @click="startNewFolder">New</button> from folder section header
- UX-14: remove inline new-folder <div v-if="showNewFolderInput"> input block
- UX-03: replace Loading… divs with animate-pulse skeleton rows (3-row pattern) in
  all three sections (folders, cloud, topics)
- UX-01 sidebar micro: wire EmptyState size=sm for each empty section
  - folders: icon=folder headline="Create a folder in the file manager"
  - cloud: icon=cloud headline="Connect in Settings" with #cta Settings link
  - topics: icon=tag headline="No topics yet"
- Add EmptyState import; StorageBrowser.startNewFolder untouched (invariant)
- Update tests to work with script setup (Composition API) reality; all 9 GREEN
2026-06-15 20:27:54 +02:00
curo1305 b076ec9cda docs(10-06): create plan summary — skeleton/EmptyState/BreadcrumbBar/toast wired
- Documents 3 tasks (TDD RED→GREEN→Task3)
- Records 164/164 tests passing, FolderBreadcrumb deleted
- Captures dead-code hygiene deviation and decisions
2026-06-15 20:27:15 +02:00
curo1305 3e79423cfd feat(10-08): BreadcrumbBar in remaining admin views + SettingsView; EmptyState in SharedView + CloudStorageView
- AdminQuotasView: BreadcrumbBar (Quotas, showRoot=false)
- AdminAiView: BreadcrumbBar (AI Config, showRoot=false)
- AdminOverviewView: BreadcrumbBar (empty segments, showRoot=false) above existing h2
- SettingsView: BreadcrumbBar with breadcrumbSegments computed (Settings > activeTabLabel)
- SharedView: BreadcrumbBar (Shared with me) + EmptyState (icon=inbox)
- CloudStorageView: BreadcrumbBar in toolbar + EmptyState (icon=cloud) with Settings router-link CTA
- Full test suite: 178 passed, 0 failures
2026-06-15 20:27:00 +02:00
curo1305 9ea51d6401 feat(10-06): wire breadcrumb mapping + toast call sites; delete FolderBreadcrumb
- FileManagerView: add mappedBreadcrumb computed ({id,label} from foldersStore.breadcrumb)
- FileManagerView: import useToastStore; add toast.show() to doMove, doDeleteDoc, onFilesSelected
- FileManagerView: remove console.error from doMove/doDeleteDoc (toast communicates errors)
- CloudFolderView: add mappedBreadcrumb computed; pass to StorageBrowser :breadcrumb
- Delete FolderBreadcrumb.vue + FolderBreadcrumb.test.js (no dead code per CLAUDE.md)
- FileManagerView.test.js: replace dead FolderBreadcrumb mock with BreadcrumbBar mock
- StorageBrowser.skeleton.test.js: remove unused FolderBreadcrumb stub
- Full suite: 164/164 pass, 0 failures
2026-06-15 20:26:06 +02:00
curo1305 8e360f4f21 feat(10-08): skeleton tables + BreadcrumbBar + EmptyState in AdminAuditView and AdminUsersView
- AdminAuditView: add BreadcrumbBar (Audit Log, showRoot=false), replace loading spinner with 8-row skeleton tbody, replace empty div with EmptyState (icon=clipboardList) + Clear filters CTA
- AdminUsersView: add BreadcrumbBar (Users, showRoot=false), replace loading spinner with 5-row x 6-col skeleton tbody
- Promote CTA test to use real EmptyState (no stub) so slot content renders
- All 8 skeleton tests pass GREEN
2026-06-15 20:25:05 +02:00
curo1305 3fcc300ebe test(10-07): promote AppSidebar.empty stubs to RED tests (UX-01, UX-03, UX-14)
- Replace 10 it.todo stubs with 9 real tests across 3 describe blocks
- UX-03: 3 tests verify skeleton rows during loading (folders/topics/cloud)
- UX-01 sidebar micro: 3 tests verify EmptyState size=sm for each empty section
- UX-14: 3 tests verify "New" button gone, methods removed, no inline folder input
- 8/9 tests RED (1 passes trivially: input hidden while showNewFolderInput=false)
- Adapted for script setup (Composition API) rather than Options API as described in plan
2026-06-15 20:23:41 +02:00
curo1305 d040e77548 feat(10-06): update StorageBrowser — skeleton rows, EmptyState, BreadcrumbBar swap
- Replace FolderBreadcrumb import with BreadcrumbBar + EmptyState imports
- Replace <FolderBreadcrumb> with <BreadcrumbBar :root-label="mode === 'cloud' ? 'Cloud' : 'Home'">
- Replace Loading… div with 5 animated skeleton rows (animate-pulse, grid-cols-[2rem_1fr_6rem_8rem_6rem])
- Replace inline empty-state divs with three <EmptyState> blocks (search/in-folder/root)
- UX-02 skeleton tests green (4/4)
2026-06-15 20:23:34 +02:00
curo1305 ec5fd23ec2 test(10-08): promote admin skeleton stubs to real RED tests — 8 failing tests
- AdminAuditView.skeleton.test.js: 5 real assertions (skeleton rows, cell count, no loading text, EmptyState, CTA)
- AdminUsersView.skeleton.test.js: 3 real assertions (skeleton rows, 6 cells, no loading text)
- All 8 tests fail until Task 2 updates the view components
2026-06-15 20:22:34 +02:00
curo1305 413d3f0ff7 test(10-06): promote UX-02 skeleton stubs to RED failing tests
- Replace 4 it.todo stubs with real assertions for animate-pulse, Loading text, and grid class
- Keep UX-13 todo block unchanged (promoted in plan 10-12)
- setActivePinia per test; stub BreadcrumbBar/SearchBar/SortControls/DropZone/UploadProgress/TopicBadge/AppIcon/EmptyState
2026-06-15 20:22:26 +02:00
curo1305 a1885122a1 docs(phase-10): update tracking after wave 0 complete (5/12 plans) 2026-06-15 20:18:49 +02:00
curo1305 20183e9c5e chore: merge executor worktree (10-03 BreadcrumbBar) 2026-06-15 20:17:57 +02:00
curo1305 8e1fb9e1db chore: merge executor worktree (10-02 EmptyState) — kept 10-01 AppIcon.vue (resolvedPaths vs paths[name]; 10-01 is canonical) 2026-06-15 20:17:49 +02:00
curo1305 5ed6ae9565 chore: merge executor worktree (10-05 Nyquist stubs) 2026-06-15 20:17:06 +02:00
curo1305 b4bcc1d843 docs(10-03): complete BreadcrumbBar plan — 2/2 tasks, 10/10 tests green 2026-06-15 20:14:30 +02:00
curo1305 ce76c097fd docs(10-05): complete Wave 0 xfail test stubs plan — 8 files, 53 it.todo stubs covering UX-02..09, UX-11, UX-13, UX-14 2026-06-15 20:13:57 +02:00
curo1305 7e584e032a feat(10-03): implement BreadcrumbBar.vue — shared breadcrumb component (GREEN)
- Options API component with segments/{id?,label}, rootLabel, showRoot props
- Emits navigate(segment.id) for intermediate clicks, navigate(null) for root
- Computed visibleSegments collapses >4 segments to first+ellipsis+last two
- Segments without id render as plain non-clickable spans (admin static segments)
- Uses AppIcon for chevronRight separator (no inline SVG)
- All 10 Vitest tests pass
- Also creates AppIcon.vue (Rule 3: BreadcrumbBar imports it)
2026-06-15 20:13:29 +02:00
curo1305 69e859d2d8 docs(10-02): complete EmptyState plan — 2 tasks, 7 tests green
- EmptyState.vue: Options API, 4 props, 4 computed size-class methods, #cta slot
- AppIcon.vue: created as deviation Rule 3 (unblocks import resolution)
- 7 Vitest tests: RED at 96f4b5f, GREEN at e56d17e
2026-06-15 20:13:10 +02:00
curo1305 794ff42bf5 test(10-05): Wave 0 keyboard + OS-drag + drag-to-move stubs (UX-05..09, UX-11)
- keyboard.test.js: 11 it.todo stubs for UX-05 search focus, UX-06 escape clear, UX-07 upload picker, UX-08 new folder
- OsDragOverlay.test.js: 7 it.todo stubs for UX-09 OS file drag overlay depth-counter + teleport
- StorageBrowser.dragmove.test.js: 6 it.todo stubs for UX-11 drag-to-move ring highlight + toast wiring
2026-06-15 20:12:39 +02:00
curo1305 bb52aa09e0 docs(10-04): complete toast notification system plan
- 2/2 tasks executed (TDD RED then GREEN)
- 10 tests green; SettingsAccountTab + TotpEnrollment regressions clean
- toast.js store implemented, ToastContainer.vue created, App.vue mounted
2026-06-15 20:12:28 +02:00
curo1305 e56d17efcb feat(10-02): implement EmptyState.vue — shared empty-state component (GREEN)
- Options API component with props: icon, headline, subtext, size
- Computed containerClass/iconClass/headlineClass/subtextClass for md and sm variants
- Named #cta slot with no fallback content
- Imports AppIcon from ./AppIcon.vue (child component)
- Also creates AppIcon.vue (deviation Rule 3: required to resolve EmptyState import)
- All 7 EmptyState tests pass; all 144 tests pass
2026-06-15 20:12:09 +02:00
curo1305 848b5fcf36 docs(10-01): complete AppIcon plan — 32 icons, 6/6 tests green
- AppIcon.vue: 31 single-path + 1 dual-path (cog) registry
- 6 unit tests cover name→path, class forwarding, dual-path, svg attrs, unknown-name warn, stroke path attrs
- Full frontend suite: 153/153 passed
2026-06-15 20:11:58 +02:00
curo1305 75970352fc test(10-05): Wave 0 skeleton + dropdown stubs (UX-02, UX-03, UX-04, UX-13, UX-14)
- StorageBrowser.skeleton.test.js: 7 it.todo stubs for UX-02 skeleton rows + UX-13 Teleport dropdown
- AppSidebar.empty.test.js: 10 it.todo stubs for UX-03 skeleton, UX-01 micro empty states, UX-14 inline-New removal
- AdminAuditView.skeleton.test.js: 5 it.todo stubs for UX-04 audit skeleton + UX-01 empty state
- AdminUsersView.skeleton.test.js: 3 it.todo stubs for UX-04 users skeleton
- dropdown.test.js: 4 it.todo stubs for UX-13 Teleport+getBoundingClientRect pattern
2026-06-15 20:11:40 +02:00
curo1305 b6ea858c9b test(10-03): add failing BreadcrumbBar tests (RED)
- 10 Vitest unit tests covering showRoot, rootLabel, navigate emits
- Tests segments shape {id?, label} (not {id, name})
- Covers ellipsis collapse for >4 segments, no-id static segments
- AppIcon stubbed via global.stubs for isolated rendering
2026-06-15 20:11:37 +02:00
curo1305 f92d98d067 feat(10-04): implement toast store, ToastContainer, mount in App.vue
- toast.js: reactive toasts array, show/dismiss with auto-dismiss via setTimeout
- ToastContainer.vue: Options API, Teleport to body, TransitionGroup, data-test attr
- type-to-class maps: accentClass/iconName/iconColorClass for success/error/warning/info
- App.vue: import and mount <ToastContainer /> after layout div
- all 10 tests pass; SettingsAccountTab and TotpEnrollment regressions green
2026-06-15 20:11:12 +02:00
curo1305 74fc41cefa feat(10-01): implement AppIcon.vue with full ICON_PATHS registry
- Options API component with inheritAttrs: false for class forwarding
- 32 named icons: 31 single-path + 1 dual-path (cog as Array)
- resolvedPaths computed warns in DEV for unknown icon names
- v-if guard renders nothing for unknown names
- Array.isArray check renders v-for paths for dual-path icons
- All 6 AppIcon tests pass (GREEN)
2026-06-15 20:10:41 +02:00
curo1305 96f4b5f80e test(10-02): add failing EmptyState tests (RED)
- 7 it() blocks covering prop rendering, slot rendering, and size variants
- Tests stub AppIcon via global.stubs to avoid ordering dependency
- All 7 tests fail with module-not-found (EmptyState.vue not yet created)
2026-06-15 20:10:15 +02:00
curo1305 b12137c4ce test(10-04): add failing tests for toast store and ToastContainer
- 6 toast store tests: show/dismiss/auto-dismiss/duration=0/stacking
- 4 ToastContainer tests: empty/render count/click dismiss/accent class
- uses vi.useFakeTimers() for timer-based assertions
- Teleport and AppIcon stubbed for DOM-safe mounting
2026-06-15 20:10:00 +02:00
curo1305 4a45dd4801 test(10-01): add failing AppIcon tests for icon registry contract
- 6 tests covering name→path rendering, class forwarding, dual-path (cog), svg attrs, unknown-name warn, and path stroke attrs
- RED phase: AppIcon.vue does not exist yet; tests fail on import
2026-06-15 20:09:21 +02:00
curo1305andClaude Sonnet 4.6 d3d3f711eb docs(10): create phase plan — 12 plans, 6 waves, UX-01..14 + CODE-05
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-15 06:55:11 +02:00
curo1305 c84dcb77c1 docs(phase-10): research UX & interaction 2026-06-14 22:04:12 +02:00
curo1305 71118076a4 docs(state): record phase 10 context session 2026-06-14 21:53:38 +02:00
curo1305 4c8c394bc3 docs(10): capture phase context 2026-06-14 21:53:34 +02:00
curo1305andClaude Sonnet 4.6 e6f5f2be3b test(phase-09): complete UAT — 9/9 tests passed; mark phase complete
All 9 UAT items verified via live API + source inspection:
- GET /api/admin/overview live data (78 users, 8MB storage, 10 audit rows)
- Auth guard: 401 unauthenticated, 403 non-admin on all protected endpoints
- Admin login redirect (D-08) confirmed in LoginView.vue line 212
- Sidebar: 5 nav links, indigo Admin badge, no back-to-app link
- 4-stat-card overview + When/Event/Actor/Target/IP audit table
- 5 standalone admin views (Users, Quotas, AI, Audit) with no Pinia stores
- API key write-only invariant confirmed in AdminAiView.vue
- Color-coded audit badges (auth=blue, admin=amber, folder/share=purple)
- to.matched.some() guard covers all /admin/* child routes
- No sensitive fields (password_hash, credentials_enc) in any response

Phase 9 marked complete. STATE.md and PROJECT.md updated for Phase 10.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-13 11:32:19 +02:00
curo1305andClaude Sonnet 4.6 3363e23436 docs(phase-09): mark VALIDATION.md complete — all 5 gaps resolved
Audit confirmed all Wave 0 gaps were filled during execution:
- test_admin_overview.py: 8/8 passing (ADMIN-11 aggregate + no sensitive fields)
- router.guard.test.js: 11/11 passing (ADMIN-12 non-admin redirect + admin-to-admin guard)
- AdminView.vue absent from repo (ADMIN-08 dead-code check)
- Tailwind safelist covers all provider color classes (CODE-06)

nyquist_compliant: true

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-13 10:45:34 +02:00
curo1305andClaude Sonnet 4.6 c4adf9a990 docs(phase-09): add security threat verification — 15/15 threats closed
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-12 22:28:15 +02:00
curo1305andClaude Sonnet 4.6 6f9f045a9a docs(phase-09): add VERIFICATION.md + REVIEW.md — phase 9 complete
5/5 automated must-haves verified. 4 human runtime checks pending.
Code review: 4 blockers (CR-01 testAiConnection POST/GET mismatch,
CR-02 open redirect, CR-03 unvalidated role field, CR-04 password
shuffle bias), 6 warnings, 3 info.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-12 22:22:47 +02:00
curo1305andClaude Sonnet 4.6 baa462870d docs(phase-09): update tracking after wave 4 — plan 09-05 complete
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-12 22:09:22 +02:00
curo1305andClaude Sonnet 4.6 777c003ce9 docs(09-05): complete CODE-09 comment purge plan — SUMMARY.md
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-12 22:09:22 +02:00
curo1305andClaude Sonnet 4.6 7ef65de046 refactor(09-05): CODE-09 purge — Phase 9 files (WHAT comments removed)
Frontend: AdminLayout, AdminSidebar, AdminOverviewView, AdminUsersView,
AdminQuotasView, AdminAiView, AdminAuditView, router/index.js, LoginView,
tailwind.config.js, api/admin.js — WHAT labels stripped; WHY constraints
preserved (D-16 anchors, security notes, api_key write-only invariant,
router guard rationale, D-08/D-09/D-10 decision refs, fetchWithRetry reason).
Backend: overview.py was already clean (no WHAT comments present).
Frontend: 137 tests pass, build succeeds.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-12 21:52:30 +02:00
curo1305 3b639b7a72 chore: merge partial 09-05 — Phase 8 backend comment purge 2026-06-12 20:11:27 +02:00
curo1305 6d1c02f703 refactor(09-05): CODE-09 purge — Phase 8 backend sub-packages (WHAT comments removed)
- api/admin/users.py: removed module docstring + 7 WHAT function docstrings
- api/admin/quotas.py: removed module docstring + 2 WHAT function docstrings
- api/admin/ai.py: removed module docstring + 3 WHAT inline comments; security invariant docstrings preserved
- api/admin/shared.py: unchanged (all comments are WHY — constraint notes)
- api/documents/upload.py: removed 4 WHAT inline comments; T-03-05/T-03-06 WHY notes preserved
- api/documents/content.py: removed WHAT function docstring + WHAT inline comment
- api/documents/crud.py: removed 7 WHAT inline comments; D-16 + security constraint docstrings preserved
- api/auth/shared.py: removed module docstring + 1 WHAT inline comment
- api/auth/tokens.py: removed module docstring + 8 WHAT function docstrings/comments; family-revocation + SEC-02 WHY notes preserved
- api/auth/totp.py: removed module docstring + 2 WHAT function docstrings + 2 WHAT inline comments
- api/auth/password.py: removed module docstring + 2 WHAT function docstrings + 3 WHAT inline comments
- All NO-prefix anchor comments and security-invariant WHY comments preserved
- pytest: 413 passed, 1 failed (pre-existing ModuleNotFoundError unrelated to purge)
2026-06-12 16:59:46 +02:00