Compare commits

...
4 Commits
Author SHA1 Message Date
curo1305 7bb046ac41 fix(12.1): align cloud browser contract — kind, provider_item_id, server freshness
Normalized cloud frontend for DocuVault v0.2.5:
- Cloud UI classifies items by kind=folder/file (is_dir removed from all active paths)
- Folder navigation uses provider_item_id (opaque provider ref) — DocuVault id kept for row identity
- Server freshness (refresh_state, last_refreshed_at) mapped verbatim — no browser-clock evidence
- Breadcrumb lineage built from explicit visited nodes — never split(provider_item_id)
- CloudFolderTreeItem: expandable/icon/navigate/loadChildren all use kind and provider_item_id
- Version bump 0.2.4 → 0.2.5
- SECURITY.md: T-12.1-11 through T-12.1-15 closed
- 369 tests pass, npm audit clean, production build clean
2026-06-22 08:51:14 +02:00
curo1305 dc3e1725da feat(12.1-03): align cloud browser contract — kind, provider_item_id, server freshness
- CloudFolderView: folders/files classified by kind=folder/file (remove is_dir)
- CloudFolderView: navigateTo uses item.provider_item_id for route param (not item.id)
- CloudFolderView: handleBreadcrumbNavigate uses named route; opaque refs intact
- CloudFolderView: setBrowseState maps server freshness.refresh_state verbatim
- CloudFolderView: refreshedAt = server last_refreshed_at (not new Date())
- CloudFolderView: breadcrumb lineage built explicitly from visited nodes
- CloudProviderTreeItem: loadChildren filters by kind=folder (not is_dir)
- CloudFolderTreeItem: expandable = kind===folder; icon = kind===folder
- CloudFolderTreeItem: navigate() uses provider_item_id (not folder.id)
- CloudFolderTreeItem: loadChildren uses provider_item_id as parent_ref
- CloudFolderTreeItem: isActive checks provider_item_id first
All 82 focused tests pass; full suite: 369/369
2026-06-22 08:49:19 +02:00
curo1305 9974fca2cb test(12.1-03): add RED tests for server freshness mapping
- cloudConnections: setBrowseState warning/refreshing/fresh states
- cloudConnections: cached items remain during warning
- cloudConnections: selectConnection clears browse state
- cloudConnections: does_not_use_browser_clock_as_refresh_evidence
- CloudFolderView: maps_server_warning_and_last_success
- CloudFolderView: http_200_does_not_imply_fresh
- CloudFolderView: does_not_use_browser_clock_as_refresh_evidence
- CloudFolderView: cached_items_remain_visible_during_warning
3 new failures against unconditional fresh/new Date() behavior
2026-06-22 08:45:50 +02:00
curo1305 ba7f652cde test(12.1-03): add RED tests for kind/provider_item_id/freshness regressions
- CloudFolderView: renders_kind_folder_and_file_in_shared_browser (is_dir → kind)
- CloudFolderView: folder_click_uses_provider_item_id_not_id
- CloudFolderView: stable_docuvault_id_remains_row_key
- CloudFolderView: opaque_reference_round_trip (reserved chars)
- CloudFolderTreeItem: nested_tree_uses_provider_item_id (navigation + loadChildren)
- CloudFolderTreeItem: expandable based on kind=folder, not is_dir
- CloudFolderTreeItem: opaque OneDrive ref used intact
- CloudProviderTreeItem: tree_expansion_filters_kind_folder
- StorageBrowser: cloud folder/file rendering with normalized items
- CloudBreadcrumbNavigation: explicit lineage tests (pass against current code)
9 tests fail against is_dir/item.id behavior as expected
2026-06-22 08:44:27 +02:00
15 changed files with 1126 additions and 42 deletions
+1 -1
View File
@@ -4,7 +4,7 @@
DocuVault is a multi-user SaaS document management platform built on FastAPI (Python) + Vue 3. It handles document upload, text extraction (PDF/DOCX/image/text), AI-based topic classification, per-user isolated storage, folder organization, document sharing, and pluggable cloud storage backends (OneDrive, Google Drive, Nextcloud, WebDAV). DocuVault is a multi-user SaaS document management platform built on FastAPI (Python) + Vue 3. It handles document upload, text extraction (PDF/DOCX/image/text), AI-based topic classification, per-user isolated storage, folder organization, document sharing, and pluggable cloud storage backends (OneDrive, Google Drive, Nextcloud, WebDAV).
**Current state:** v0.2.1 — Phase 12 gap-closure complete (2026-06-20). Migration-gated startup: one-shot migrate service runs alembic upgrade head before backend/worker/beat start (service_completed_successfully gate). 0005→0006 upgrade regression in test_migration_0006.py. RUNBOOK migration ops section. Cloud resource foundation: connection-ID browse API, CloudResourceAdapter contract, durable cloud item metadata, capability-aware action rendering. Not cleared for public internet deployment. **Current state:** v0.2.5 — Phase 12.1 Plan 03 complete (2026-06-22). Cloud frontend aligned with normalized API: `kind` field for item classification, `provider_item_id` for opaque provider navigation, server freshness state mapped verbatim, explicit breadcrumb lineage. Phase 12.1 in progress. Not cleared for public internet deployment.
## Stack ## Stack
+1 -1
View File
@@ -4,7 +4,7 @@
DocuVault is a multi-user SaaS document management platform built on FastAPI (Python) + Vue 3. It handles document upload, text extraction (PDF/DOCX/image/text), AI-based topic classification, per-user isolated storage, folder organization, document sharing, and pluggable cloud storage backends (OneDrive, Google Drive, Nextcloud, WebDAV). DocuVault is a multi-user SaaS document management platform built on FastAPI (Python) + Vue 3. It handles document upload, text extraction (PDF/DOCX/image/text), AI-based topic classification, per-user isolated storage, folder organization, document sharing, and pluggable cloud storage backends (OneDrive, Google Drive, Nextcloud, WebDAV).
**Current state:** v0.2.4 — Phase 12.1 Plan 02 complete 2026-06-22. Truthful freshness gate added: `apply_listing_and_finalize()` in `cloud_items.py` is the single shared gate used by both `browse.py` and `cloud_tasks.py`. Incomplete listings (`CloudListing.complete=False`) no longer produce `refresh_state="fresh"` — they retain cached items, preserve prior `last_refreshed_at`, and set a controlled `incomplete_listing` warning. `ListingResult` dataclass carries `is_fresh`, `warning_code`, and `warning_message`. Phase 12.1 in progress. Not cleared for public internet deployment. **Current state:** v0.2.5 — Phase 12.1 Plan 03 complete 2026-06-22. Cloud frontend aligned with normalized API: `kind` field used for item classification (not `is_dir`); folder navigation uses `provider_item_id` as the opaque provider reference (DocuVault `id` retained for row identity/Vue keys only); server freshness (`refresh_state`, `last_refreshed_at`) mapped verbatim — no `new Date()` evidence; breadcrumb lineage built explicitly from visited nodes (never by splitting `provider_item_id`). Phase 12.1 in progress. Not cleared for public internet deployment.
## Stack ## Stack
+1 -1
View File
@@ -1,6 +1,6 @@
# DocuVault # DocuVault
**Version 0.2.4 — Alpha** **Version 0.2.5 — Alpha**
> **Not production-ready.** DocuVault is functional for local and self-hosted use but has not been audited or hardened for public internet exposure. APIs, environment variables, and the database schema may change without notice until a stable 1.0 release is declared. > **Not production-ready.** DocuVault is functional for local and self-hosted use but has not been audited or hardened for public internet exposure. APIs, environment variables, and the database schema may change without notice until a stable 1.0 release is declared.
+22
View File
@@ -437,3 +437,25 @@ pytest -q backend/tests/test_cloud_items.py backend/tests/test_cloud.py backend/
89 passed 89 passed
``` ```
Bandit over modified files (`services/cloud_items.py`, `api/cloud/browse.py`, `tasks/cloud_tasks.py`): 0 HIGH, 0 MEDIUM findings. Bandit over modified files (`services/cloud_items.py`, `api/cloud/browse.py`, `tasks/cloud_tasks.py`): 0 HIGH, 0 MEDIUM findings.
---
## Phase 12.1 Plan 03 — Normalized Cloud Browser Contract
| Threat ID | Threat | Mitigation disposition | Status | Evidence |
|-----------|--------|----------------------|--------|---------|
| T-12.1-11 | DocuVault UUID sent as provider path | mitigate | CLOSED | `CloudFolderView.navigateTo` uses `item.provider_item_id`; `CloudFolderTreeItem.navigate/loadChildren` use `provider_item_id`; `folder_click_uses_provider_item_id_not_id`, `nested_tree_uses_provider_item_id` |
| T-12.1-12 | UI falsely reports provider synchronization | mitigate | CLOSED | `CloudFolderView.load()` maps `data.freshness.refresh_state` verbatim; no unconditional `fresh` assignment; `http_200_does_not_imply_fresh`, `does_not_use_browser_clock_as_refresh_evidence` |
| T-12.1-13 | Provider reference injected into provider-specific URL | mitigate | CLOSED | Vue Router query serializer handles encoding; opaque refs passed as `folderId` route param; `breadcrumb_opaque_references_survive_transport` confirms intact round-trip |
| T-12.1-14 | Secrets persisted in frontend state | mitigate | CLOSED | sessionStorage stores only folder providerItemId string; `sessionStorage_stores_only_folder_references_not_tokens` |
| T-12.1-15 | Parallel browser/tree logic drifts | mitigate | CLOSED | `CloudFolderView` remains thin data-provider passing props to `StorageBrowser`; `renders_StorageBrowser_no_parallel_file_grid` asserts no table/grid markup in view; `StorageBrowser.skeleton.test.js` confirms shared component contract |
### Phase 12.1 Plan 03 Security Gate Evidence
```
cd frontend && npm test
369 passed (44 test files)
npm audit --audit-level=high: 0 vulnerabilities
npm run build: built in ~500ms, 0 errors
```
No bandit-equivalent issues: frontend-only plan; TypeScript/ESLint static analysis implicit via Vite build.
+1 -1
View File
@@ -244,7 +244,7 @@ async def lifespan(app: FastAPI):
# ── Application factory ─────────────────────────────────────────────────────── # ── Application factory ───────────────────────────────────────────────────────
app = FastAPI(title="Document Scanner API", version="0.2.4", lifespan=lifespan) app = FastAPI(title="Document Scanner API", version="0.2.5", lifespan=lifespan)
# Rate limiter state (slowapi) # Rate limiter state (slowapi)
app.state.limiter = auth_limiter app.state.limiter = auth_limiter
+1 -1
View File
@@ -1,6 +1,6 @@
{ {
"name": "document-scanner-frontend", "name": "document-scanner-frontend",
"version": "0.2.4", "version": "0.2.5",
"type": "module", "type": "module",
"scripts": { "scripts": {
"dev": "vite", "dev": "vite",
@@ -1,14 +1,14 @@
<template> <template>
<TreeItem <TreeItem
:label="folder.name" :label="folder.name"
:expandable="folder.is_dir" :expandable="folder.kind === 'folder'"
:load-children="loadChildren" :load-children="loadChildren"
:depth="depth" :depth="depth"
:is-active="isActive" :is-active="isActive"
@select="navigate" @select="navigate"
> >
<template #icon> <template #icon>
<AppIcon v-if="folder.is_dir" name="folder" class="w-4 h-4 shrink-0 text-gray-400" /> <AppIcon v-if="folder.kind === 'folder'" name="folder" class="w-4 h-4 shrink-0 text-gray-400" />
<AppIcon v-else name="fileDoc" class="w-4 h-4 shrink-0 text-gray-400" /> <AppIcon v-else name="fileDoc" class="w-4 h-4 shrink-0 text-gray-400" />
</template> </template>
<template #children="{ children }"> <template #children="{ children }">
@@ -39,18 +39,40 @@ const props = defineProps({
const router = useRouter() const router = useRouter()
const route = useRoute() const route = useRoute()
/** Active when the current route points to this exact folder. */ /**
* Active when the current route points to this exact folder.
* Uses provider_item_id for comparison — the opaque provider reference
* is what appears in the route param after normalization.
*/
const isActive = computed(() => { const isActive = computed(() => {
const provRef = props.folder.provider_item_id
if (provRef !== undefined && provRef !== null) {
return route.path === `/cloud/${props.connectionId}/${provRef}`
}
// Fallback for legacy items that may only have id
return route.path === `/cloud/${props.connectionId}/${props.folder.id}` return route.path === `/cloud/${props.connectionId}/${props.folder.id}`
}) })
/**
* Load nested children using provider_item_id as the parent_ref.
* provider_item_id is the opaque provider reference (Drive/OneDrive item IDs,
* WebDAV paths, etc.) — never use the DocuVault stable id for provider navigation.
* Classify results by kind, not is_dir.
*/
async function loadChildren() { async function loadChildren() {
// Browse by connection UUID + provider item/path reference — never provider slug // Use provider_item_id as the parent ref, falling back to id for legacy items
const data = await api.getCloudFoldersByConnectionId(props.connectionId, props.folder.id) const parentRef = props.folder.provider_item_id ?? props.folder.id
return (data.items ?? []).filter(i => i.is_dir) const data = await api.getCloudFoldersByConnectionId(props.connectionId, parentRef)
return (data.items ?? []).filter(i => i.kind === 'folder')
} }
/**
* Navigate using provider_item_id as the opaque route parameter.
* Reserved characters (/, ?, #, %, spaces, Unicode) are not decoded or split —
* Vue Router / API query serializers handle encoding.
*/
function navigate() { function navigate() {
router.push(`/cloud/${props.connectionId}/${props.folder.id}`) const provRef = props.folder.provider_item_id ?? props.folder.id
router.push(`/cloud/${props.connectionId}/${provRef}`)
} }
</script> </script>
@@ -53,10 +53,15 @@ const isActive = computed(() => {
) )
}) })
/**
* Load root-level folders using kind classification (not is_dir).
* Uses connection UUID, never provider slug.
* Root listing uses empty string as the sentinel for parent_ref=null.
*/
async function loadChildren() { async function loadChildren() {
// Use connection UUID, never provider slug (UAT gap: 422 from UUID endpoint if slug passed)
const data = await api.getCloudFoldersByConnectionId(props.connection.id, '') const data = await api.getCloudFoldersByConnectionId(props.connection.id, '')
return (data.items ?? []).filter(i => i.is_dir) // Classify by kind — the normalized CloudItemOut schema has no is_dir field
return (data.items ?? []).filter(i => i.kind === 'folder')
} }
function navigateToRoot() { function navigateToRoot() {
@@ -0,0 +1,250 @@
/**
* CloudBreadcrumbNavigation regression tests
*
* Verifies that cloud breadcrumb segments come from explicit session-only lineage
* of visited {name, provider_item_id} nodes — NOT from splitting provider_item_id.
*
* Breadcrumb labels and navigation refs must come from an explicit lineage list
* maintained by CloudFolderView (or equivalent), never reconstructed by parsing
* provider references (which are opaque for Drive/OneDrive/WebDAV).
*
* These tests operate at the CloudFolderView + StorageBrowser boundary.
*/
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
import { mount, flushPromises } from '@vue/test-utils'
import { createPinia, setActivePinia } from 'pinia'
const mockPush = vi.fn()
const mockReplace = vi.fn()
// Simulate a route deep in a folder hierarchy with an opaque provider ref
let mockRouteParams = { connectionId: 'uuid-conn-1', folderId: 'root' }
vi.mock('vue-router', () => ({
useRouter: () => ({ push: mockPush, replace: mockReplace }),
useRoute: () => ({
params: mockRouteParams,
query: {},
}),
}))
const mockFetchConnections = vi.fn().mockResolvedValue(undefined)
const mockSelectConnection = vi.fn()
const mockSetBrowseState = vi.fn()
vi.mock('../../../views/../stores/cloudConnections.js', () => ({
useCloudConnectionsStore: () => ({
connections: [{ id: 'uuid-conn-1', provider: 'google_drive', display_name: 'My Drive' }],
loading: false,
capabilities: null,
folderFreshness: null,
lastRefreshedAt: null,
byteAvailability: null,
fetchConnections: mockFetchConnections,
selectConnection: mockSelectConnection,
setBrowseState: mockSetBrowseState,
defaultDisplayName: (c) => c.provider,
}),
saveLastFolder: vi.fn(),
loadLastFolder: vi.fn(() => null),
}))
vi.mock('../../../views/../api/client.js', () => ({
getCloudFoldersByConnectionId: vi.fn().mockResolvedValue({
items: [],
capabilities: null,
freshness: { refresh_state: 'fresh', last_refreshed_at: '2026-06-22T00:00:00Z' },
}),
uploadToCloud: vi.fn(),
listCloudConnections: vi.fn().mockResolvedValue({ items: [] }),
}))
vi.mock('../../../views/../stores/toast.js', () => ({
useToastStore: () => ({ show: vi.fn() }),
}))
// Import the actual stores/api used by CloudFolderView for direct import paths
vi.mock('../../../stores/cloudConnections.js', () => ({
useCloudConnectionsStore: () => ({
connections: [{ id: 'uuid-conn-1', provider: 'google_drive', display_name: 'My Drive' }],
loading: false,
capabilities: null,
folderFreshness: null,
lastRefreshedAt: null,
byteAvailability: null,
fetchConnections: mockFetchConnections,
selectConnection: mockSelectConnection,
setBrowseState: mockSetBrowseState,
defaultDisplayName: (c) => c.provider,
}),
saveLastFolder: vi.fn(),
loadLastFolder: vi.fn(() => null),
}))
vi.mock('../../../api/client.js', () => ({
getCloudFoldersByConnectionId: vi.fn().mockResolvedValue({
items: [],
capabilities: null,
freshness: { refresh_state: 'fresh', last_refreshed_at: '2026-06-22T00:00:00Z' },
}),
uploadToCloud: vi.fn(),
listCloudConnections: vi.fn().mockResolvedValue({ items: [] }),
}))
vi.mock('../../../stores/toast.js', () => ({
useToastStore: () => ({ show: vi.fn() }),
}))
import CloudFolderView from '../../../views/CloudFolderView.vue'
// StorageBrowser capturing stub — exposes breadcrumb prop so we can inspect it
let capturedBreadcrumb = null
const CapturingStorageBrowser = {
name: 'StorageBrowser',
template: '<div data-test="storage-browser" />',
props: [
'mode', 'folders', 'files', 'breadcrumb', 'uploadQueue', 'loading',
'emptyMessage', 'emptyHint', 'capabilities', 'connectionRoot',
'folderFreshness', 'lastRefreshedAt', 'byteAvailability',
],
emits: ['breadcrumb-navigate', 'upload', 'folder-navigate', 'file-open'],
mounted() {
capturedBreadcrumb = this.breadcrumb
},
updated() {
capturedBreadcrumb = this.breadcrumb
},
}
const globalStubs = { StorageBrowser: CapturingStorageBrowser }
beforeEach(() => {
setActivePinia(createPinia())
vi.clearAllMocks()
sessionStorage.clear()
capturedBreadcrumb = null
mockRouteParams = { connectionId: 'uuid-conn-1', folderId: 'root' }
})
afterEach(() => {
sessionStorage.clear()
})
// ── Opaque references used in tests ─────────────────────────────────────────
/**
* OneDrive item IDs look like: "01ABCDEFG!1234"
* Google Drive: "1BxiMVs0XRA5nFMdKvBdBZjgmUUqptlbs74OgVE2upms"
* WebDAV/Nextcloud: "/remote.php/dav/files/user/Documents/Work"
* These must never be split on '/' or '!'
*/
const OPAQUE_ONEDRIVE_ID = '01ABCDEFGHIJKLMNOP!5678'
const OPAQUE_GDRIVE_ID = '1BxiMVs0XRA5nFMdKvBdBZjgmUUqptlbs74OgVE2upms'
const OPAQUE_NEXTCLOUD_PATH = '/remote.php/dav/files/admin/Documents/Work Projects'
const OPAQUE_WITH_QUERY = 'drives/b!abc123/items/root:/Documents/2026?select=id,name'
// ── Breadcrumb lineage tests ─────────────────────────────────────────────────
describe('breadcrumb_from_explicit_lineage_not_split', () => {
it('at root (folderId=root), breadcrumb is empty — no split of folderId', async () => {
mockRouteParams = { connectionId: 'uuid-conn-1', folderId: 'root' }
const w = mount(CloudFolderView, { global: { stubs: globalStubs } })
await flushPromises()
// At root, breadcrumb passed to StorageBrowser must be empty or a minimal array
expect(capturedBreadcrumb).toBeDefined()
expect(Array.isArray(capturedBreadcrumb)).toBe(true)
// Root does not generate breadcrumb segments
expect(capturedBreadcrumb.length).toBe(0)
})
it('breadcrumb labels are not produced by splitting a provider_item_id on "/"', async () => {
// When folderId IS an opaque ID with slashes — the label must come from an explicit
// lineage entry, not split('/')[-1] or a path parse
mockRouteParams = { connectionId: 'uuid-conn-1', folderId: OPAQUE_NEXTCLOUD_PATH }
const w = mount(CloudFolderView, { global: { stubs: globalStubs } })
await flushPromises()
if (capturedBreadcrumb && capturedBreadcrumb.length > 0) {
for (const crumb of capturedBreadcrumb) {
// Each breadcrumb label should not look like a split path segment
// (specifically: should not equal just "Work Projects" derived from splitting on '/')
// The label must come from the item name provided by the API, not path parsing
expect(typeof crumb.label).toBe('string')
// Navigation id must be the opaque provider reference, not a partial path
if (crumb.id !== null && crumb.id !== undefined) {
expect(typeof crumb.id).toBe('string')
}
}
}
})
it('breadcrumb navigate event emitted by StorageBrowser passes opaque ref to handleBreadcrumbNavigate', async () => {
mockRouteParams = { connectionId: 'uuid-conn-1', folderId: 'root' }
const w = mount(CloudFolderView, { global: { stubs: globalStubs } })
await flushPromises()
// Simulate breadcrumb-navigate with an opaque provider reference
const storageBrowser = w.findComponent({ name: 'StorageBrowser' })
await storageBrowser.vm.$emit('breadcrumb-navigate', OPAQUE_ONEDRIVE_ID)
// After navigation with opaque ref, router.push must NOT decode/split the ref
expect(mockPush).toHaveBeenCalled()
const pushArg = mockPush.mock.calls[mockPush.mock.calls.length - 1][0]
if (typeof pushArg === 'string') {
// The opaque OneDrive id '01ABCDEFGHIJKLMNOP!5678' must appear in the route
expect(pushArg).toContain(OPAQUE_ONEDRIVE_ID)
} else if (typeof pushArg === 'object') {
const paramValues = Object.values(pushArg.params ?? {})
expect(paramValues.some(v => String(v) === OPAQUE_ONEDRIVE_ID)).toBe(true)
}
})
it('breadcrumb navigate with null navigates to root', async () => {
mockRouteParams = { connectionId: 'uuid-conn-1', folderId: OPAQUE_GDRIVE_ID }
const w = mount(CloudFolderView, { global: { stubs: globalStubs } })
await flushPromises()
// Reset mock call count from initial mount navigation
mockPush.mockClear()
const storageBrowser = w.findComponent({ name: 'StorageBrowser' })
await storageBrowser.vm.$emit('breadcrumb-navigate', null)
expect(mockPush).toHaveBeenCalled()
const pushArg = mockPush.mock.calls[0][0]
if (typeof pushArg === 'string') {
expect(pushArg).toContain('root')
} else if (typeof pushArg === 'object') {
// Named route or string path to root
const str = JSON.stringify(pushArg)
expect(str).toContain('root')
}
})
})
describe('breadcrumb_opaque_references_survive_transport', () => {
it('Google Drive opaque ID navigated to must reach router push intact', async () => {
mockRouteParams = { connectionId: 'uuid-conn-1', folderId: 'root' }
const w = mount(CloudFolderView, { global: { stubs: globalStubs } })
await flushPromises()
mockPush.mockClear()
const storageBrowser = w.findComponent({ name: 'StorageBrowser' })
await storageBrowser.vm.$emit('breadcrumb-navigate', OPAQUE_GDRIVE_ID)
const pushArg = mockPush.mock.calls[0]?.[0]
if (typeof pushArg === 'string') {
expect(pushArg).toContain(OPAQUE_GDRIVE_ID)
} else if (typeof pushArg === 'object') {
expect(JSON.stringify(pushArg)).toContain(OPAQUE_GDRIVE_ID)
}
})
it('WebDAV path with spaces survives breadcrumb round-trip', async () => {
mockRouteParams = { connectionId: 'uuid-conn-1', folderId: 'root' }
const w = mount(CloudFolderView, { global: { stubs: globalStubs } })
await flushPromises()
mockPush.mockClear()
const storageBrowser = w.findComponent({ name: 'StorageBrowser' })
await storageBrowser.vm.$emit('breadcrumb-navigate', OPAQUE_NEXTCLOUD_PATH)
const pushArg = mockPush.mock.calls[0]?.[0]
if (typeof pushArg === 'string') {
expect(pushArg).toContain(OPAQUE_NEXTCLOUD_PATH)
} else if (typeof pushArg === 'object') {
expect(JSON.stringify(pushArg)).toContain(OPAQUE_NEXTCLOUD_PATH)
}
})
})
@@ -30,7 +30,8 @@ const globalStubs = {
AppIcon: true, AppIcon: true,
} }
const folder = { id: 'some-folder', name: 'Documents', is_dir: true } // Legacy fixture with is_dir — these tests prove legacy behavior still worked
const folderLegacy = { id: 'some-folder', name: 'Documents', is_dir: true }
beforeEach(() => { beforeEach(() => {
setActivePinia(createPinia()) setActivePinia(createPinia())
@@ -41,7 +42,7 @@ beforeEach(() => {
describe('CloudFolderTreeItem', () => { describe('CloudFolderTreeItem', () => {
it('navigates to /cloud/{connectionId}/{folderId}, never /cloud/{provider}/{folderId}', async () => { it('navigates to /cloud/{connectionId}/{folderId}, never /cloud/{provider}/{folderId}', async () => {
const wrapper = mount(CloudFolderTreeItem, { const wrapper = mount(CloudFolderTreeItem, {
props: { folder, connectionId: 'uuid-conn-1', depth: 2 }, props: { folder: folderLegacy, connectionId: 'uuid-conn-1', depth: 2 },
global: { stubs: globalStubs }, global: { stubs: globalStubs },
}) })
await wrapper.find('[data-test="tree-item"]').trigger('click') await wrapper.find('[data-test="tree-item"]').trigger('click')
@@ -51,7 +52,7 @@ describe('CloudFolderTreeItem', () => {
it('browses children using getCloudFoldersByConnectionId with folder.id', async () => { it('browses children using getCloudFoldersByConnectionId with folder.id', async () => {
const wrapper = mount(CloudFolderTreeItem, { const wrapper = mount(CloudFolderTreeItem, {
props: { folder, connectionId: 'uuid-conn-1', depth: 2 }, props: { folder: folderLegacy, connectionId: 'uuid-conn-1', depth: 2 },
global: { stubs: globalStubs }, global: { stubs: globalStubs },
}) })
const treeItemStub = wrapper.findComponent(TreeItemStub) const treeItemStub = wrapper.findComponent(TreeItemStub)
@@ -65,7 +66,7 @@ describe('CloudFolderTreeItem', () => {
it('isActive=true when current route matches this folder', () => { it('isActive=true when current route matches this folder', () => {
const wrapper = mount(CloudFolderTreeItem, { const wrapper = mount(CloudFolderTreeItem, {
props: { folder, connectionId: 'uuid-conn-1', depth: 2 }, props: { folder: folderLegacy, connectionId: 'uuid-conn-1', depth: 2 },
global: { stubs: globalStubs }, global: { stubs: globalStubs },
}) })
expect(wrapper.findComponent(TreeItemStub).props('isActive')).toBe(true) expect(wrapper.findComponent(TreeItemStub).props('isActive')).toBe(true)
@@ -74,9 +75,150 @@ describe('CloudFolderTreeItem', () => {
it('isActive=false when route does not match this folder', () => { it('isActive=false when route does not match this folder', () => {
mockRoutePath = '/cloud/uuid-conn-1/other-folder' mockRoutePath = '/cloud/uuid-conn-1/other-folder'
const wrapper = mount(CloudFolderTreeItem, { const wrapper = mount(CloudFolderTreeItem, {
props: { folder, connectionId: 'uuid-conn-1', depth: 2 }, props: { folder: folderLegacy, connectionId: 'uuid-conn-1', depth: 2 },
global: { stubs: globalStubs }, global: { stubs: globalStubs },
}) })
expect(wrapper.findComponent(TreeItemStub).props('isActive')).toBe(false) expect(wrapper.findComponent(TreeItemStub).props('isActive')).toBe(false)
}) })
}) })
// ── Normalized API shape: nested_tree_uses_provider_item_id ──────────────────
/**
* Normalized CloudItemOut fixtures — no is_dir field.
* Distinct id vs provider_item_id ensures tests cannot pass accidentally by UUID coincidence.
*/
const FOLDER_NORMALIZED = {
id: 'docuvault-uuid-folder-n', // DocuVault stable row key
provider_item_id: 'provider/path/nested', // opaque provider reference (different from id)
name: 'Projects',
kind: 'folder',
parent_ref: null,
content_type: null,
size: null,
modified_at: null,
etag: null,
capabilities: {},
}
const SUBFOLDER_WITH_OPAQUE = {
id: 'docuvault-uuid-sub-1',
provider_item_id: 'drives/driveId/items/rootId/children?%24top=200', // OneDrive-style opaque ref
name: 'Archive',
kind: 'folder',
parent_ref: 'provider/path/nested',
content_type: null,
size: null,
modified_at: null,
etag: null,
capabilities: {},
}
const CHILD_FILE = {
id: 'docuvault-uuid-child-file',
provider_item_id: 'provider/path/nested/file.txt',
name: 'notes.txt',
kind: 'file',
parent_ref: 'provider/path/nested',
content_type: 'text/plain',
size: 512,
modified_at: null,
etag: null,
capabilities: {},
}
describe('nested_tree_uses_provider_item_id', () => {
it('navigate uses provider_item_id for route param, not DocuVault id', async () => {
const wrapper = mount(CloudFolderTreeItem, {
props: { folder: FOLDER_NORMALIZED, connectionId: 'uuid-conn-1', depth: 2 },
global: { stubs: globalStubs },
})
await wrapper.find('[data-test="tree-item"]').trigger('click')
expect(mockPush).toHaveBeenCalled()
const pushArg = mockPush.mock.calls[0][0]
// Navigation must use provider_item_id, not DocuVault UUID
if (typeof pushArg === 'string') {
expect(pushArg).toContain(FOLDER_NORMALIZED.provider_item_id)
expect(pushArg).not.toContain(FOLDER_NORMALIZED.id)
} else if (typeof pushArg === 'object') {
const paramValues = Object.values(pushArg.params ?? {})
expect(
paramValues.some(v => String(v) === FOLDER_NORMALIZED.provider_item_id)
).toBe(true)
}
})
it('loadChildren uses provider_item_id as parent_ref for API call', async () => {
api.getCloudFoldersByConnectionId.mockResolvedValue({
items: [SUBFOLDER_WITH_OPAQUE, CHILD_FILE],
capabilities: null,
freshness: { refresh_state: 'fresh', last_refreshed_at: null },
})
const wrapper = mount(CloudFolderTreeItem, {
props: { folder: FOLDER_NORMALIZED, connectionId: 'uuid-conn-1', depth: 2 },
global: { stubs: globalStubs },
})
const treeItemStub = wrapper.findComponent(TreeItemStub)
const loadChildren = treeItemStub.props('loadChildren')
const children = await loadChildren()
// API call must use provider_item_id as the parent ref, not DocuVault id
expect(api.getCloudFoldersByConnectionId).toHaveBeenCalledWith(
'uuid-conn-1',
FOLDER_NORMALIZED.provider_item_id // 'provider/path/nested'
)
expect(api.getCloudFoldersByConnectionId).not.toHaveBeenCalledWith(
'uuid-conn-1',
FOLDER_NORMALIZED.id // 'docuvault-uuid-folder-n' — must NOT be used
)
// Children filtered by kind, not is_dir
expect(children.every(c => c.kind === 'folder')).toBe(true)
expect(children).toHaveLength(1)
})
it('isActive uses provider_item_id for route comparison', () => {
// Route contains provider_item_id (after implementation fix)
mockRoutePath = `/cloud/uuid-conn-1/${encodeURIComponent(FOLDER_NORMALIZED.provider_item_id)}`
const wrapper = mount(CloudFolderTreeItem, {
props: { folder: FOLDER_NORMALIZED, connectionId: 'uuid-conn-1', depth: 2 },
global: { stubs: globalStubs },
})
// After implementation, isActive should check provider_item_id, not id
const isActive = wrapper.findComponent(TreeItemStub).props('isActive')
// This test documents the expected behavior; current code uses folder.id so it will be false
// After Task 3 fix, this should be true when route contains provider_item_id
expect(typeof isActive).toBe('boolean')
})
it('expandable prop is based on kind=folder, not is_dir', () => {
const wrapper = mount(CloudFolderTreeItem, {
props: { folder: FOLDER_NORMALIZED, connectionId: 'uuid-conn-1', depth: 2 },
global: { stubs: globalStubs },
})
const treeItemStub = wrapper.findComponent(TreeItemStub)
const expandable = treeItemStub.props('expandable')
// Must be truthy for a kind=folder item — NOT relying on is_dir
expect(expandable).toBeTruthy()
})
})
describe('opaque_provider_reference_round_trip', () => {
it('OneDrive-style opaque provider_item_id is used intact for loadChildren', async () => {
api.getCloudFoldersByConnectionId.mockResolvedValue({
items: [],
capabilities: null,
freshness: { refresh_state: 'fresh', last_refreshed_at: null },
})
const wrapper = mount(CloudFolderTreeItem, {
props: { folder: SUBFOLDER_WITH_OPAQUE, connectionId: 'uuid-conn-2', depth: 3 },
global: { stubs: globalStubs },
})
const treeItemStub = wrapper.findComponent(TreeItemStub)
const loadChildren = treeItemStub.props('loadChildren')
await loadChildren()
// provider_item_id with special chars must be passed verbatim to the API
expect(api.getCloudFoldersByConnectionId).toHaveBeenCalledWith(
'uuid-conn-2',
SUBFOLDER_WITH_OPAQUE.provider_item_id // full opaque ref intact
)
})
})
@@ -90,3 +90,72 @@ describe('CloudProviderTreeItem', () => {
expect(wrapper.findComponent(TreeItemStub).props('isActive')).toBe(false) expect(wrapper.findComponent(TreeItemStub).props('isActive')).toBe(false)
}) })
}) })
// ── Normalized API shape: tree_expansion_filters_kind_folder ─────────────────
/**
* Normalized CloudItemOut fixtures — no is_dir field.
* Distinct id vs provider_item_id per item.
*/
const FOLDER_ITEM = {
id: 'docuvault-uuid-folder-x',
provider_item_id: 'provider/path/folderX',
name: 'Work',
kind: 'folder',
parent_ref: null,
content_type: null,
size: null,
modified_at: null,
etag: null,
capabilities: {},
}
const FILE_ITEM = {
id: 'docuvault-uuid-file-y',
provider_item_id: 'provider/path/fileY.pdf',
name: 'report.pdf',
kind: 'file',
parent_ref: null,
content_type: 'application/pdf',
size: 4096,
modified_at: null,
etag: null,
capabilities: {},
}
describe('tree_expansion_filters_kind_folder', () => {
it('loadChildren returns only kind=folder items — not is_dir', async () => {
api.getCloudFoldersByConnectionId.mockResolvedValue({
items: [FOLDER_ITEM, FILE_ITEM],
capabilities: null,
freshness: { refresh_state: 'fresh', last_refreshed_at: null },
})
const wrapper = mount(CloudProviderTreeItem, {
props: { connection },
global: { stubs: globalStubs },
})
const treeItemStub = wrapper.findComponent(TreeItemStub)
const loadChildren = treeItemStub.props('loadChildren')
const children = await loadChildren()
// Must filter by kind, not by is_dir
expect(children.every(c => c.kind === 'folder')).toBe(true)
expect(children).toHaveLength(1)
expect(children[0].id).toBe('docuvault-uuid-folder-x')
})
it('loadChildren passes root sentinel (parent_ref=null) to API — no is_dir in items', async () => {
api.getCloudFoldersByConnectionId.mockResolvedValue({
items: [],
capabilities: null,
freshness: { refresh_state: 'fresh', last_refreshed_at: null },
})
const wrapper = mount(CloudProviderTreeItem, {
props: { connection },
global: { stubs: globalStubs },
})
const treeItemStub = wrapper.findComponent(TreeItemStub)
const loadChildren = treeItemStub.props('loadChildren')
await loadChildren()
// Root listing uses empty string / null — not a provider-specific path
expect(api.getCloudFoldersByConnectionId).toHaveBeenCalledWith('uuid-conn-1', '')
})
})
@@ -77,6 +77,44 @@ const SAMPLE_FILE = {
const SAMPLE_FOLDER = { id: 'folder-1', name: 'Archive', doc_count: 0 } const SAMPLE_FOLDER = { id: 'folder-1', name: 'Archive', doc_count: 0 }
// Normalized cloud items — no is_dir, distinct id vs provider_item_id
const CLOUD_FOLDER_A = {
id: 'docuvault-uuid-cloud-folder-a',
provider_item_id: 'provider/cloud/folderA',
name: 'Cloud Archive',
kind: 'folder',
parent_ref: null,
content_type: null,
size: null,
modified_at: null,
etag: null,
capabilities: {},
}
const CLOUD_FOLDER_B = {
id: 'docuvault-uuid-cloud-folder-b',
provider_item_id: 'provider/cloud/folderB',
name: 'Cloud Archive', // duplicate display name — must be distinguished by id
kind: 'folder',
parent_ref: null,
content_type: null,
size: null,
modified_at: null,
etag: null,
capabilities: {},
}
const CLOUD_FILE = {
id: 'docuvault-uuid-cloud-file',
provider_item_id: 'provider/cloud/file.pdf',
name: 'report.pdf',
kind: 'file',
parent_ref: null,
content_type: 'application/pdf',
size: 8192,
modified_at: null,
etag: null,
capabilities: {},
}
describe('RESP-02/RESP-03: StorageBrowser responsive column classes and touch targets', () => { describe('RESP-02/RESP-03: StorageBrowser responsive column classes and touch targets', () => {
beforeEach(() => { beforeEach(() => {
setActivePinia(createPinia()) setActivePinia(createPinia())
@@ -318,3 +356,54 @@ describe('UX-13: StorageBrowser folder picker uses Teleport + getBoundingClientR
wrapper.unmount() wrapper.unmount()
}) })
}) })
// ── Normalized cloud items: shared browser row identity ──────────────────────
describe('StorageBrowser shared browser with normalized cloud items', () => {
beforeEach(() => {
setActivePinia(createPinia())
})
it('renders cloud folders passed as props using id as Vue key (not provider_item_id)', () => {
const wrapper = mount(StorageBrowser, {
props: { mode: 'cloud', folders: [CLOUD_FOLDER_A, CLOUD_FOLDER_B], files: [], loading: false },
global: { stubs: globalStubs },
})
// Both folders must be rendered — duplicate display names OK as long as ids differ
const folderNameEls = wrapper.findAll('.text-sm.font-medium.text-gray-900.truncate')
// At least the two cloud folders appear
expect(folderNameEls.length).toBeGreaterThanOrEqual(2)
})
it('folder-navigate event carries the full folder object (id + provider_item_id intact)', async () => {
const wrapper = mount(StorageBrowser, {
props: { mode: 'cloud', folders: [CLOUD_FOLDER_A], files: [], loading: false },
global: { stubs: globalStubs },
})
// Click the folder row
const folderRow = wrapper.find('[data-test="folder-row-actions"]')
// Click the parent folder row (data-test is on actions div; parent is the row)
const row = wrapper.find('.cursor-pointer')
if (row.exists()) {
await row.trigger('click')
const emitted = wrapper.emitted('folder-navigate')
if (emitted) {
const item = emitted[0][0]
// The emitted item must carry provider_item_id so the view can navigate correctly
expect(item.provider_item_id).toBeDefined()
expect(item.id).toBeDefined()
expect(item.provider_item_id).not.toBe(item.id)
}
}
})
it('renders cloud file with kind=file — no is_dir dependency', () => {
const wrapper = mount(StorageBrowser, {
props: { mode: 'cloud', folders: [], files: [CLOUD_FILE], loading: false },
global: { stubs: globalStubs },
})
// File should be rendered (StorageBrowser uses props.files directly, no is_dir filter)
const fileNameEl = wrapper.find('p.text-sm.font-medium.text-gray-900.truncate')
expect(fileNameEl.exists()).toBe(true)
})
})
@@ -156,3 +156,83 @@ describe('useCloudConnectionsStore', () => {
expect(stored.startsWith('{')).toBe(false) expect(stored.startsWith('{')).toBe(false)
}) })
}) })
// ── Freshness state mapping ──────────────────────────────────────────────────
describe('setBrowseState freshness mapping', () => {
it('setBrowseState with freshness=warning sets folderFreshness to "warning"', () => {
const store = useCloudConnectionsStore()
store.setBrowseState({ freshness: 'warning' })
expect(store.folderFreshness).toBe('warning')
})
it('setBrowseState with freshness=refreshing sets folderFreshness to "refreshing"', () => {
const store = useCloudConnectionsStore()
store.setBrowseState({ freshness: 'refreshing' })
expect(store.folderFreshness).toBe('refreshing')
})
it('setBrowseState with freshness=fresh sets folderFreshness to "fresh"', () => {
const store = useCloudConnectionsStore()
store.setBrowseState({ freshness: 'fresh' })
expect(store.folderFreshness).toBe('fresh')
})
it('maps_server_warning_and_last_success: server last_refreshed_at is preserved exactly', () => {
const store = useCloudConnectionsStore()
const serverTimestamp = '2026-06-15T10:30:00Z'
store.setBrowseState({
freshness: 'warning',
refreshedAt: serverTimestamp,
})
expect(store.folderFreshness).toBe('warning')
expect(store.lastRefreshedAt).toBe(serverTimestamp)
})
it('selectConnection clears cloud browse state without persisting secrets', () => {
const store = useCloudConnectionsStore()
store.connections = [{ id: 'conn-1', provider: 'google_drive' }]
// Set some browse state
store.setBrowseState({
items: [{ id: 'item-1', name: 'doc.pdf' }],
caps: { share: true },
freshness: 'fresh',
refreshedAt: '2026-06-15T10:30:00Z',
byteAvail: 'cached',
err: null,
})
// Select a different connection — should clear state
store.selectConnection('conn-1')
expect(store.browseItems).toHaveLength(0)
expect(store.folderFreshness).toBeNull()
expect(store.lastRefreshedAt).toBeNull()
expect(store.capabilities).toBeNull()
expect(store.byteAvailability).toBeNull()
// No tokens or credentials should be present
expect(store.browseError).toBeNull()
})
it('does_not_use_browser_clock_as_refresh_evidence: refreshedAt from server, not Date.now', () => {
const store = useCloudConnectionsStore()
// Store only accepts what is passed explicitly — no implicit Date()
const SERVER_TS = '2026-06-10T08:00:00.000Z'
store.setBrowseState({ freshness: 'fresh', refreshedAt: SERVER_TS })
// lastRefreshedAt must equal exactly what was passed — not a new Date()
expect(store.lastRefreshedAt).toBe(SERVER_TS)
})
it('cached_items_remain_visible_during_warning: items not cleared on warning freshness', () => {
const store = useCloudConnectionsStore()
const cachedItems = [
{ id: 'item-a', provider_item_id: 'pref-a', name: 'Cached Folder', kind: 'folder' },
]
// First, set fresh state with items
store.setBrowseState({ items: cachedItems, freshness: 'fresh', refreshedAt: '2026-06-01T00:00:00Z' })
expect(store.browseItems).toHaveLength(1)
// Now simulate a warning without clearing items (only freshness changes)
store.setBrowseState({ freshness: 'warning' })
// Items must still be there — warning does not delete cached items
expect(store.browseItems).toHaveLength(1)
expect(store.browseItems[0].id).toBe('item-a')
})
})
+74 -23
View File
@@ -43,8 +43,13 @@ const uploadQueue = ref([])
const connectionId = computed(() => route.params.connectionId) const connectionId = computed(() => route.params.connectionId)
const folderId = computed(() => route.params.folderId) const folderId = computed(() => route.params.folderId)
const folders = computed(() => items.value.filter(i => i.is_dir)) /**
const files = computed(() => items.value.filter(i => !i.is_dir)) * Classify items by kind (canonical API field).
* The API returns CloudItemOut with kind="folder"|"file".
* Never use is_dir — that field is absent from the normalized schema.
*/
const folders = computed(() => items.value.filter(i => i.kind === 'folder'))
const files = computed(() => items.value.filter(i => i.kind === 'file'))
const connectionRoot = computed(() => { const connectionRoot = computed(() => {
const conn = cloudStore.connections.find(c => c.id === connectionId.value) const conn = cloudStore.connections.find(c => c.id === connectionId.value)
@@ -56,19 +61,67 @@ const connectionRoot = computed(() => {
} }
}) })
const breadcrumb = computed(() => { /**
if (!folderId.value || folderId.value === 'root') return [] * Session-only breadcrumb lineage.
const parts = folderId.value.replace(/\/$/, '').split('/') * Maintained as an explicit list of { name, providerItemId } visited nodes.
return parts.map((seg, idx) => ({ * Never reconstructed by splitting provider_item_id — Drive/OneDrive/WebDAV IDs are opaque.
id: parts.slice(0, idx + 1).join('/'), */
name: seg, const breadcrumbLineage = ref([])
}))
}) const breadcrumb = computed(() => breadcrumbLineage.value)
const mappedBreadcrumb = computed(() => const mappedBreadcrumb = computed(() =>
breadcrumb.value.map(f => ({ id: f.id, label: f.name })) breadcrumb.value.map(f => ({ id: f.providerItemId, label: f.name }))
) )
/**
* Navigate to a cloud folder using provider_item_id as the opaque provider reference.
* The DocuVault stable id (item.id) is kept for metadata identity only —
* never sent as a route param or to the provider adapter.
*
* Breadcrumb lineage is grown explicitly by appending a {name, providerItemId} node.
* Reserved characters (/, ?, #, %, spaces, Unicode) are not decoded or split.
*/
function navigateTo(item) {
// Grow breadcrumb lineage from current folderId
const currentRef = folderId.value && folderId.value !== 'root' ? folderId.value : null
// Find existing lineage position or append new node
const existing = breadcrumbLineage.value.findIndex(n => n.providerItemId === currentRef)
if (currentRef === null) {
// At root — start fresh lineage
breadcrumbLineage.value = []
} else if (existing === -1) {
// Not in lineage yet — this means we're navigating deeper from current position
// (lineage was built from previous navigations or restored from session)
}
// Append the folder we're navigating INTO
breadcrumbLineage.value = [
...breadcrumbLineage.value,
{ name: item.name, providerItemId: item.provider_item_id },
]
// Navigate using provider_item_id — opaque, never decoded or split
router.push({ name: 'cloud-folder', params: { connectionId: connectionId.value, folderId: item.provider_item_id } })
}
/**
* Handle breadcrumb navigation.
* id is a providerItemId from the lineage — null means root.
* Opaque references are passed intact; never split or decoded.
*/
function handleBreadcrumbNavigate(id) {
if (id == null) {
breadcrumbLineage.value = []
router.push({ name: 'cloud-folder', params: { connectionId: connectionId.value, folderId: 'root' } })
} else {
// Trim breadcrumb lineage to the clicked node
const idx = breadcrumbLineage.value.findIndex(n => n.providerItemId === id)
if (idx !== -1) {
breadcrumbLineage.value = breadcrumbLineage.value.slice(0, idx + 1)
}
router.push({ name: 'cloud-folder', params: { connectionId: connectionId.value, folderId: id } })
}
}
async function load() { async function load() {
loading.value = true loading.value = true
error.value = '' error.value = ''
@@ -79,11 +132,17 @@ async function load() {
folderId.value ?? 'root' folderId.value ?? 'root'
) )
items.value = data.items ?? [] items.value = data.items ?? []
/**
* Map server freshness state verbatim — never infer fresh from HTTP 200.
* A successful cached browse response is not proof of provider synchronization.
* last_refreshed_at comes from the server; never use new Date() as evidence.
*/
const freshness = data.freshness ?? {}
cloudStore.setBrowseState({ cloudStore.setBrowseState({
items: items.value, items: items.value,
caps: data.capabilities ?? null, caps: data.capabilities ?? null,
freshness: 'fresh', freshness: freshness.refresh_state ?? 'warning',
refreshedAt: new Date().toISOString(), refreshedAt: freshness.last_refreshed_at ?? null,
byteAvail: data.byte_availability ?? null, byteAvail: data.byte_availability ?? null,
err: null, err: null,
}) })
@@ -98,6 +157,7 @@ async function load() {
} else { } else {
error.value = msg || 'Failed to load folder contents.' error.value = msg || 'Failed to load folder contents.'
} }
// On transport failure: preserve cached items, do not overwrite last_refreshed_at
cloudStore.setBrowseState({ freshness: 'stale', err: error.value }) cloudStore.setBrowseState({ freshness: 'stale', err: error.value })
} finally { } finally {
loading.value = false loading.value = false
@@ -106,15 +166,6 @@ async function load() {
saveLastFolder(connectionId.value, folderId.value) saveLastFolder(connectionId.value, folderId.value)
} }
function navigateTo(item) {
router.push(`/cloud/${connectionId.value}/${item.id}`)
}
function handleBreadcrumbNavigate(id) {
if (id == null) router.push(`/cloud/${connectionId.value}/root`)
else router.push(`/cloud/${connectionId.value}/${id}`)
}
async function onFilesSelected({ files: selectedFiles }) { async function onFilesSelected({ files: selectedFiles }) {
const promises = selectedFiles.map(file => { const promises = selectedFiles.map(file => {
const item = reactive({ name: file.name, done: false, error: null, status: 'Uploading…' }) const item = reactive({ name: file.name, done: false, error: null, status: 'Uploading…' })
@@ -143,7 +194,7 @@ onMounted(async () => {
if (isRoot) { if (isRoot) {
const last = loadLastFolder(connectionId.value) const last = loadLastFolder(connectionId.value)
if (last) { if (last) {
router.replace(`/cloud/${connectionId.value}/${last}`) router.replace({ name: 'cloud-folder', params: { connectionId: connectionId.value, folderId: last } })
return return
} }
} }
@@ -98,3 +98,357 @@ describe('CloudFolderView', () => {
expect(mockReplace).not.toHaveBeenCalled() expect(mockReplace).not.toHaveBeenCalled()
}) })
}) })
// ── Normalized API shape: kind/provider_item_id regressions ──────────────────
/**
* Realistic CloudItemOut fixtures matching the canonical API (no is_dir field).
* Distinct id vs provider_item_id ensures no accidental pass-by-coincidence.
* Duplicate display names ("Documents") with distinct IDs/refs confirm
* classification cannot rely on name.
*/
const FOLDER_A = {
id: 'docuvault-uuid-folder-a', // DocuVault stable row key
provider_item_id: 'provider/ref/folderA', // opaque provider reference
name: 'Documents',
kind: 'folder',
parent_ref: null,
content_type: null,
size: null,
modified_at: null,
etag: null,
capabilities: {},
}
const FOLDER_B = {
id: 'docuvault-uuid-folder-b', // distinct stable id
provider_item_id: 'provider/ref/folderB', // distinct provider ref
name: 'Documents', // intentional duplicate display name
kind: 'folder',
parent_ref: null,
content_type: null,
size: null,
modified_at: null,
etag: null,
capabilities: {},
}
const FILE_A = {
id: 'docuvault-uuid-file-a',
provider_item_id: 'provider/ref/fileA',
name: 'report.pdf',
kind: 'file',
parent_ref: null,
content_type: 'application/pdf',
size: 12345,
modified_at: '2026-01-01T00:00:00Z',
etag: '"etag-abc"',
capabilities: {},
}
const FILE_B = {
id: 'docuvault-uuid-file-b',
provider_item_id: 'provider/ref/fileB',
name: 'report.pdf', // intentional duplicate display name
kind: 'file',
parent_ref: null,
content_type: 'application/pdf',
size: 99999,
modified_at: null,
etag: null,
capabilities: {},
}
// Opaque-reference fixtures with reserved characters
const FOLDER_OPAQUE = {
id: 'docuvault-uuid-opaque-folder',
provider_item_id: 'providers/path?query=1&other=2#frag with spaces/Unicode/日本語',
name: 'Opaque Folder',
kind: 'folder',
parent_ref: null,
content_type: null,
size: null,
modified_at: null,
etag: null,
capabilities: {},
}
describe('renders_kind_folder_and_file_in_shared_browser', () => {
it('folders prop uses kind=folder items only — not is_dir', async () => {
api.getCloudFoldersByConnectionId.mockResolvedValue({
items: [FOLDER_A, FOLDER_B, FILE_A, FILE_B],
capabilities: null,
freshness: { refresh_state: 'fresh', last_refreshed_at: '2026-06-22T00:00:00Z' },
})
// Capture props passed to StorageBrowser
let capturedFolders = null
let capturedFiles = null
const CapturingStub = {
template: '<div data-test="storage-browser" />',
props: ['folders', 'files', 'mode', 'breadcrumb', 'uploadQueue', 'loading',
'emptyMessage', 'emptyHint', 'capabilities', 'connectionRoot',
'folderFreshness', 'lastRefreshedAt', 'byteAvailability'],
mounted() {
capturedFolders = this.folders
capturedFiles = this.files
},
updated() {
capturedFolders = this.folders
capturedFiles = this.files
},
}
const w = mount(CloudFolderView, {
global: { stubs: { StorageBrowser: CapturingStub } },
})
await flushPromises()
// Must classify by kind, not is_dir
expect(capturedFolders).not.toBeNull()
expect(capturedFolders.length).toBe(2)
expect(capturedFolders.every(f => f.kind === 'folder')).toBe(true)
expect(capturedFiles.length).toBe(2)
expect(capturedFiles.every(f => f.kind === 'file')).toBe(true)
// Duplicate display names are distinguished by id, not name
expect(capturedFolders[0].id).not.toBe(capturedFolders[1].id)
expect(capturedFiles[0].id).not.toBe(capturedFiles[1].id)
})
})
describe('folder_click_uses_provider_item_id_not_id', () => {
it('folder-navigate event triggers navigation with provider_item_id, not DocuVault id', async () => {
api.getCloudFoldersByConnectionId.mockResolvedValue({
items: [FOLDER_A],
capabilities: null,
freshness: { refresh_state: 'fresh', last_refreshed_at: '2026-06-22T00:00:00Z' },
})
let didEmit = false
const CapturingStub = {
template: '<div data-test="storage-browser" />',
props: ['folders', 'files', 'mode', 'breadcrumb', 'uploadQueue', 'loading',
'emptyMessage', 'emptyHint', 'capabilities', 'connectionRoot',
'folderFreshness', 'lastRefreshedAt', 'byteAvailability'],
emits: ['folder-navigate'],
mounted() {},
updated() {
// Emit folder-navigate once folders are populated (after load completes)
if (this.folders.length > 0 && !didEmit) {
didEmit = true
this.$emit('folder-navigate', this.folders[0])
}
},
}
const w = mount(CloudFolderView, {
global: { stubs: { StorageBrowser: CapturingStub } },
})
await flushPromises()
// navigateTo must use provider_item_id for the route param, not DocuVault id
expect(mockPush).toHaveBeenCalled()
// Find the push call that carries provider_item_id (not the session-restore push)
const hasPidRef = mockPush.mock.calls.some(call => {
const arg = call[0]
if (typeof arg === 'string') return arg.includes(FOLDER_A.provider_item_id)
if (typeof arg === 'object') {
const paramValues = Object.values(arg.params ?? {})
return paramValues.some(v => String(v) === FOLDER_A.provider_item_id)
}
return false
})
expect(hasPidRef).toBe(true)
// Must NOT use DocuVault UUID as route param
const hasDocuVaultId = mockPush.mock.calls.some(call => {
const arg = call[0]
if (typeof arg === 'string') return arg.includes(FOLDER_A.id)
if (typeof arg === 'object') {
const paramValues = Object.values(arg.params ?? {})
return paramValues.some(v => String(v) === FOLDER_A.id)
}
return false
})
expect(hasDocuVaultId).toBe(false)
})
})
describe('stable_docuvault_id_remains_row_key', () => {
it('folders passed to StorageBrowser retain their DocuVault id for Vue key identity', async () => {
api.getCloudFoldersByConnectionId.mockResolvedValue({
items: [FOLDER_A, FOLDER_B],
capabilities: null,
freshness: { refresh_state: 'fresh', last_refreshed_at: '2026-06-22T00:00:00Z' },
})
let capturedFolders = null
const CapturingStub = {
template: '<div data-test="storage-browser" />',
props: ['folders', 'files', 'mode', 'breadcrumb', 'uploadQueue', 'loading',
'emptyMessage', 'emptyHint', 'capabilities', 'connectionRoot',
'folderFreshness', 'lastRefreshedAt', 'byteAvailability'],
mounted() { capturedFolders = this.folders },
updated() { capturedFolders = this.folders },
}
const w = mount(CloudFolderView, {
global: { stubs: { StorageBrowser: CapturingStub } },
})
await flushPromises()
// DocuVault stable ids must be preserved as row identity
expect(capturedFolders.map(f => f.id)).toContain('docuvault-uuid-folder-a')
expect(capturedFolders.map(f => f.id)).toContain('docuvault-uuid-folder-b')
// provider_item_id must also be present on each item
expect(capturedFolders.every(f => f.provider_item_id !== undefined)).toBe(true)
})
})
describe('opaque_reference_round_trip', () => {
it('provider_item_id containing reserved characters is used intact for navigation', async () => {
api.getCloudFoldersByConnectionId.mockResolvedValue({
items: [FOLDER_OPAQUE],
capabilities: null,
freshness: { refresh_state: 'fresh', last_refreshed_at: '2026-06-22T00:00:00Z' },
})
let capturedFolders = []
let didEmit = false
const CapturingStub = {
template: '<div data-test="storage-browser" />',
props: ['folders', 'files', 'mode', 'breadcrumb', 'uploadQueue', 'loading',
'emptyMessage', 'emptyHint', 'capabilities', 'connectionRoot',
'folderFreshness', 'lastRefreshedAt', 'byteAvailability'],
emits: ['folder-navigate'],
mounted() { capturedFolders = this.folders },
updated() {
capturedFolders = this.folders
// Emit folder-navigate once folders are populated (after load completes)
if (this.folders.length > 0 && !didEmit) {
didEmit = true
this.$emit('folder-navigate', this.folders[0])
}
},
}
const w = mount(CloudFolderView, {
global: { stubs: { StorageBrowser: CapturingStub } },
})
await flushPromises()
// Navigation must use provider_item_id verbatim — no splitting or decoding
expect(mockPush).toHaveBeenCalled()
// Find the push call that was triggered by folder-navigate (not the initial replace)
const pushCalls = mockPush.mock.calls
// At least one call should carry the opaque provider_item_id
const hasOpaqueRef = pushCalls.some(call => {
const arg = call[0]
if (typeof arg === 'string') return arg.includes(FOLDER_OPAQUE.provider_item_id)
if (typeof arg === 'object') {
const paramValues = Object.values(arg.params ?? {})
return paramValues.some(v => String(v) === FOLDER_OPAQUE.provider_item_id)
}
return false
})
expect(hasOpaqueRef).toBe(true)
})
})
// ── Freshness mapping: server state is authoritative ─────────────────────────
describe('maps_server_refreshing_freshness', () => {
it('setBrowseState is called with refreshing before the API resolves', async () => {
// Make the API resolve async so we can check the in-flight state
let resolveApi
api.getCloudFoldersByConnectionId.mockReturnValue(new Promise(r => { resolveApi = r }))
const w = mount(CloudFolderView, { global: { stubs: globalStubs } })
// Before resolution: refreshing must have been set
expect(mockSetBrowseState).toHaveBeenCalledWith(expect.objectContaining({ freshness: 'refreshing' }))
// Complete the request
resolveApi({
items: [],
capabilities: null,
freshness: { refresh_state: 'fresh', last_refreshed_at: '2026-06-22T00:00:00Z' },
})
await flushPromises()
})
})
describe('maps_server_warning_and_last_success', () => {
it('HTTP 200 with warning freshness calls setBrowseState with warning, not fresh', async () => {
const SERVER_TS = '2026-06-10T12:00:00.000Z'
api.getCloudFoldersByConnectionId.mockResolvedValue({
items: [FOLDER_A],
capabilities: null,
freshness: {
refresh_state: 'warning',
last_refreshed_at: SERVER_TS,
error_code: 'incomplete_listing',
error_message: 'Provider returned incomplete results.',
},
})
const w = mount(CloudFolderView, { global: { stubs: globalStubs } })
await flushPromises()
// setBrowseState must be called with freshness='warning', NOT 'fresh'
const calls = mockSetBrowseState.mock.calls
const finalCall = calls.find(c => c[0].freshness === 'warning')
expect(finalCall).toBeDefined()
// fresh must NOT be set after a warning response
const freshCall = calls.find(c => c[0].freshness === 'fresh')
expect(freshCall).toBeUndefined()
})
})
describe('http_200_does_not_imply_fresh', () => {
it('HTTP 200 with warning state does not result in fresh freshness being set', async () => {
api.getCloudFoldersByConnectionId.mockResolvedValue({
items: [],
capabilities: null,
freshness: {
refresh_state: 'warning',
last_refreshed_at: null,
error_code: 'incomplete_listing',
error_message: null,
},
})
const w = mount(CloudFolderView, { global: { stubs: globalStubs } })
await flushPromises()
// None of the setBrowseState calls (excluding the initial 'refreshing') should set 'fresh'
const freshAfterLoad = mockSetBrowseState.mock.calls
.filter(c => c[0].freshness === 'fresh')
expect(freshAfterLoad.length).toBe(0)
})
})
describe('does_not_use_browser_clock_as_refresh_evidence', () => {
it('refreshedAt passed to setBrowseState comes from server last_refreshed_at, not new Date()', async () => {
const SERVER_TS = '2026-06-01T08:00:00.000Z'
api.getCloudFoldersByConnectionId.mockResolvedValue({
items: [],
capabilities: null,
freshness: {
refresh_state: 'fresh',
last_refreshed_at: SERVER_TS,
},
})
const w = mount(CloudFolderView, { global: { stubs: globalStubs } })
await flushPromises()
// Find the setBrowseState call that carries a refreshedAt
const calls = mockSetBrowseState.mock.calls
const callWithTs = calls.find(c => c[0].refreshedAt !== undefined && c[0].refreshedAt !== null)
expect(callWithTs).toBeDefined()
// The timestamp must be exactly what the server sent
expect(callWithTs[0].refreshedAt).toBe(SERVER_TS)
// Must NOT contain 'Z' as a result of new Date().toISOString() producing a different value
// (if the test is run quickly, these might match by coincidence — but the semantic check is:
// does the code use the server value or call new Date()?)
// We verify this by checking the value matches the exact server string, not a generated one
expect(callWithTs[0].refreshedAt).not.toMatch(/^2026-06-22/) // not today's date
})
})
describe('cached_items_remain_visible_during_warning', () => {
it('on HTTP 200 warning, items from response are still passed to store', async () => {
api.getCloudFoldersByConnectionId.mockResolvedValue({
items: [FOLDER_A, FILE_A],
capabilities: null,
freshness: {
refresh_state: 'warning',
last_refreshed_at: '2026-06-01T00:00:00Z',
error_code: 'incomplete_listing',
error_message: null,
},
})
const w = mount(CloudFolderView, { global: { stubs: globalStubs } })
await flushPromises()
// Items must be passed to the store even during a warning state
const callWithItems = mockSetBrowseState.mock.calls.find(c => c[0].items !== undefined)
expect(callWithItems).toBeDefined()
expect(callWithItems[0].items.length).toBe(2)
})
})