curo1305
b28bb01995
- Add get_regular_user FastAPI dep (rejects admin with 403) to deps/auth.py - Wire Depends(get_regular_user) into all 6 /api/documents/* handlers - upload-url: replace null-user/... object_key with str(current_user.id)/...; set user_id=current_user.id - confirm: remove Wave 2 doc.user_id is None guard — quota runs unconditionally; add ownership assertion (404 on cross-user) - list: filter by user_id=current_user.id via storage.list_metadata(user_id=...) - get/delete/classify: ownership assertion (doc.user_id != current_user.id → 404) - storage.list_metadata: add required user_id param + Document.user_id == user_id filter - storage.delete_document: remove if doc.user_id is not None guard; use CASE WHEN for SQLite-compat quota decrement - Tests: update existing tests to pass auth headers; implement test_cross_user_access_404, test_admin_cannot_access_documents, test_documents_require_auth; mark test_confirm_endpoint xfail(strict=False) for SQLite UUID mismatch
110 lines
3.5 KiB
Python
110 lines
3.5 KiB
Python
"""
|
|
FastAPI authentication dependency chain for DocuVault.
|
|
|
|
Provides two reusable FastAPI dependencies:
|
|
- get_current_user: validates the Bearer JWT and returns the User ORM object
|
|
- get_current_admin: requires user.role == 'admin' (T-02-07)
|
|
|
|
Usage in route handlers:
|
|
from deps.auth import get_current_user, get_current_admin
|
|
from db.models import User
|
|
|
|
@router.get("/me")
|
|
async def get_me(current_user: User = Depends(get_current_user)):
|
|
return {"id": str(current_user.id), "email": current_user.email}
|
|
|
|
@router.get("/admin/users")
|
|
async def list_users(
|
|
_admin: User = Depends(get_current_admin),
|
|
session: AsyncSession = Depends(get_db),
|
|
):
|
|
...
|
|
"""
|
|
import uuid
|
|
|
|
from fastapi import Depends, HTTPException, status
|
|
from fastapi.security import HTTPAuthorizationCredentials, HTTPBearer
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
from db.models import User
|
|
from deps.db import get_db
|
|
from services import auth as auth_service
|
|
|
|
# HTTPBearer parses the Authorization: Bearer <token> header.
|
|
# auto_error=True (default) raises 403 if no Authorization header is present.
|
|
security = HTTPBearer()
|
|
|
|
|
|
async def get_current_user(
|
|
credentials: HTTPAuthorizationCredentials = Depends(security),
|
|
session: AsyncSession = Depends(get_db),
|
|
) -> User:
|
|
"""Validate the Bearer JWT and return the active User ORM object.
|
|
|
|
Raises HTTP 401 if:
|
|
- Token is missing, expired, or tampered (handled by HTTPBearer + decode)
|
|
- User does not exist in the database
|
|
- User account is deactivated (is_active=False)
|
|
"""
|
|
try:
|
|
payload = auth_service.decode_access_token(credentials.credentials)
|
|
except ValueError as exc:
|
|
raise HTTPException(
|
|
status_code=status.HTTP_401_UNAUTHORIZED,
|
|
detail="Invalid or expired token",
|
|
headers={"WWW-Authenticate": "Bearer"},
|
|
) from exc
|
|
|
|
try:
|
|
user_uuid = uuid.UUID(payload["sub"])
|
|
except (KeyError, ValueError) as exc:
|
|
raise HTTPException(
|
|
status_code=status.HTTP_401_UNAUTHORIZED,
|
|
detail="Invalid token subject",
|
|
headers={"WWW-Authenticate": "Bearer"},
|
|
) from exc
|
|
|
|
user = await session.get(User, user_uuid)
|
|
if user is None or not user.is_active:
|
|
raise HTTPException(
|
|
status_code=status.HTTP_401_UNAUTHORIZED,
|
|
detail="User not found or deactivated",
|
|
headers={"WWW-Authenticate": "Bearer"},
|
|
)
|
|
|
|
return user
|
|
|
|
|
|
async def get_current_admin(
|
|
user: User = Depends(get_current_user),
|
|
) -> User:
|
|
"""Require admin role; raises HTTP 403 otherwise (T-02-07).
|
|
|
|
Admin impersonation is architecturally excluded (ADMIN-07, T-02-08):
|
|
no code path sets a JWT sub to a different user's id. This dependency
|
|
only checks that the authenticated user's role is 'admin'.
|
|
"""
|
|
if user.role != "admin":
|
|
raise HTTPException(
|
|
status_code=status.HTTP_403_FORBIDDEN,
|
|
detail="Admin access required",
|
|
)
|
|
return user
|
|
|
|
|
|
async def get_regular_user(
|
|
user: User = Depends(get_current_user),
|
|
) -> User:
|
|
"""Reject admin accounts on all /api/documents/* endpoints (D-16, SC4).
|
|
|
|
Admin accounts cannot access document content (CLAUDE.md + SEC-04).
|
|
Returns 403 (not 404) — the admin knows document endpoints exist.
|
|
Regular users are passed through unchanged.
|
|
"""
|
|
if user.role == "admin":
|
|
raise HTTPException(
|
|
status_code=status.HTTP_403_FORBIDDEN,
|
|
detail="Admin accounts cannot access document content",
|
|
)
|
|
return user
|