5.6 KiB
5.6 KiB
phase, plan, type, wave, depends_on, files_modified, autonomous, requirements
| phase | plan | type | wave | depends_on | files_modified | autonomous | requirements | |||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 14 | 01 | execute | 0 |
|
true |
|
Scope fence: add tests and fixtures only. Do not implement production code in this plan except minimal test helpers/fakes.
@.planning/ROADMAP.md @.planning/REQUIREMENTS.md @.planning/phases/14-selective-analysis-and-byte-cache/14-CONTEXT.md @.planning/phases/14-selective-analysis-and-byte-cache/14-RESEARCH.md @.planning/phases/14-selective-analysis-and-byte-cache/14-PATTERNS.md @backend/tests/test_cloud_items.py @backend/tests/test_cloud_security.py @frontend/src/components/storage/__tests__/StorageBrowser.cloud-queue.test.js Task 1: Add backend red tests for analysis and cache contracts backend/tests/test_cloud_analysis_contract.py, backend/tests/test_cloud_cache.py, backend/tests/test_cloud_analysis_api.py - backend/tests/test_cloud_items.py - backend/tests/test_cloud_security.py - backend/tests/test_cloud_mutations.py - backend/db/models.py Add focused tests using fake cloud items/connections and fake provider adapters. Cover individual-file, selection, folder, and connection estimate/enqueue requests; whole-connection estimate requirement; recursive folder choice; unsupported item reporting; duplicate unchanged version skip without provider byte fetch; owner/admin-negative access; cache entry ownership; cache object key secrecy; quota increment/decrement expectations; active pin eviction protection; retry and cancel status transitions. Mark these tests red against missing modules/endpoints rather than weakening assertions. - Tests name the exact ANALYZE/CACHE requirements they protect. - Tests assert provider bytes are not downloaded during estimate or duplicate-current checks. - Tests assert provider mutation methods are never invoked by analysis paths. - Running the new backend tests fails for missing Phase 14 implementation, not syntax/import errors in the tests themselves once modules exist. cd backend && pytest -q tests/test_cloud_analysis_contract.py tests/test_cloud_cache.py tests/test_cloud_analysis_api.py Task 2: Add frontend red tests for shared-browser analysis UX frontend/src/components/storage/__tests__/StorageBrowser.analysis-queue.test.js, frontend/src/stores/__tests__/cloudConnections.analysis.test.js - frontend/src/components/storage/StorageBrowser.vue - frontend/src/views/CloudFolderView.vue - frontend/src/stores/cloudConnections.js - frontend/src/components/storage/__tests__/StorageBrowser.cloud-queue.test.js Add tests proving row-level file analysis action, toolbar analysis for multi-select/folder/current connection, estimate modal thresholds, aggregate progress, expandable item list, simplified vs detailed labels, retry/skip/cancel controls, and Settings-backed default failure behavior. Tests must assert that `CloudFolderView` passes props and handles emits without owning layout, and that no parallel file grid is introduced. - Tests fail because analysis UI/store code is absent, not because of brittle selectors. - Shared browser remains the component under test for browser layout and controls. - Store tests cover status translation and API client calls without using localStorage/sessionStorage for credentials. cd frontend && npm run test -- StorageBrowser.analysis-queue.test.js cloudConnections.analysis.test.js<threat_model>
| Threat ID | Threat | Required test evidence |
|---|---|---|
| T-14-01 | Analysis IDOR | Foreign user cannot estimate/enqueue/status/cancel/retry another user's connection or item |
| T-14-02 | Credential/object-key disclosure | API/audit responses never include credentials, raw provider URLs, or MinIO object keys |
| T-14-03 | Hidden provider mutation | Fake adapter mutation method counters remain zero during analysis |
| T-14-04 | Hidden byte download | Estimate and already-current checks do not call provider byte fetch |
| T-14-05 | Cache quota corruption | Tests require atomic quota increment on retain and decrement on eviction |
| </threat_model> |
Create .planning/phases/14-selective-analysis-and-byte-cache/14-01-SUMMARY.md when complete.