curo/Business-Management
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat/category-scopes-group-admin #3

Closed
curo wants to merge 0 commits from feat/category-scopes-group-admin into main
pull from: feat/category-scopes-group-admin
merge into: curo:main
Conversation 0 Commits - Files Changed -
curo commented 2026-04-18 22:34:35 +02:00
Owner
Copy Link
Copy Source
No description provided.
curo added 4 commits 2026-04-18 22:34:35 +02:00
feat: category scopes, group-admin role, and permission model fec3953009 
- Three category scopes: personal / group / system (watch)
- PascalCase-with-dashes naming convention enforced at backend + frontend
- is_group_admin flag on GroupMembership; PATCH endpoint for admins to toggle it
- Categories router: scope-based list/create/rename/delete with _check_can_manage_cat
- Documents router: delete uses is_admin + can_delete share flag + group-admin check; remove_category requires doc ownership; assign_category accepts group/system categories
- Proxy layers inject x-user-is-admin and x-user-admin-groups headers
- Frontend: ManageCategoriesDialog grouped by scope with lock icons; SourcePanel scope picker + client-side name validation; AdminGroupsPage group-admin checkbox

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fix: show manage controls for system categories when user is superuser ebf97b6f4a 
canManage() returned false for system-scope categories unconditionally.
Superusers can manage all categories (backend already permits it), so
check is_admin from getMe() and short-circuit to true.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fix: capitalize watch-folder names to PascalCase-with-dashes on ingest 1c8b35399c 
Folder names like "invoices" and "vendor-invoices" are now converted to
"Invoices" and "Vendor-Invoices" when the watcher auto-creates categories,
matching the naming convention enforced on user-created categories.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fix: rename existing system categories to PascalCase-with-dashes via migration fcfc06cda9 
Migration 0007 converts all scope='system' category names in-place
(e.g. "invoices" → "Invoices", "vendor-invoices" → "Vendor-Invoices").

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
curo closed this pull request 2026-04-18 22:35:13 +02:00
curo reopened this pull request 2026-04-18 22:35:55 +02:00
curo closed this pull request 2026-04-19 02:21:42 +02:00
curo deleted branch feat/category-scopes-group-admin 2026-04-19 02:21:46 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
curo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: curo/Business-Management#3
Delete Branch "feat/category-scopes-group-admin"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?